archives/open-adventure
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

If divident negative, then remainder is negative too.

Browse source 
RNG values need to be always positive.
Solution: Transposing positively by divisor. In all the two places it may happen.
This commit is contained in:
NHOrus 2017-09-11 21:20:46 +03:00
parent 4e4c2e0198
commit 076bb8908b
2 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
misc.c
View file

@ -646,8 +646,10 @@ bool tstbit(long mask, int bit)
void set_seed(int32_t seedval) void set_seed(int32_t seedval)
/* Set the LCG seed */ /* Set the LCG seed */
{ {
game.lcg_x = (uint32_t) seedval % LCG_M; game.lcg_x = seedval % LCG_M;
if (game.lcg_x < 0) {
game.lcg_x = LCG_M + game.lcg_x;
}
// once seed is set, we need to generate the Z`ZZZ word // once seed is set, we need to generate the Z`ZZZ word
for (int i = 0; i < 5; ++i) { for (int i = 0; i < 5; ++i) {
game.zzword[i] = 'A' + randrange(26); game.zzword[i] = 'A' + randrange(26);

5
saveresume.c
View file

@ -145,6 +145,11 @@ bool is_valid(struct game_t* valgame)
valgame->lcg_x %= LCG_M; valgame->lcg_x %= LCG_M;
} }
/* Check for RNG underflow. Transpose */
if (valgame->lcg_x < LCG_M) {
valgame->lcg_x = LCG_M + (valgame->lcg_x % LCG_M);
}
/* Bounds check for locations */ /* Bounds check for locations */
if ( valgame->chloc < -1 || valgame->chloc > NLOCATIONS || if ( valgame->chloc < -1 || valgame->chloc > NLOCATIONS ||
valgame->chloc2 < -1 || valgame->chloc2 > NLOCATIONS || valgame->chloc2 < -1 || valgame->chloc2 > NLOCATIONS ||