archives/open-adventure
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

L12 is gone again. Magic numbers have been almost eliminated.

Browse source
This commit is contained in:
Eric S. Raymond 2017-06-19 08:43:51 -04:00
parent 98b02eeeb1
commit 10e53a419e
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
notes.adoc
View file

@ -117,10 +117,9 @@ ways:
and the choice to refrain will make forward translation into future and the choice to refrain will make forward translation into future
languages easier. languages easier.
* There are a few gotos left that resist restructuring; all but of these * There are a few gotos left that resist restructuring; all are in the
are in the principal command interpreter function implementing its principal command interpreter function implementing its state
state machine. the remaining one is a truly mysterious artficat in machine.
the player-movement code.
* Linked lists (for objects at a location) are implemented using an array * Linked lists (for objects at a location) are implemented using an array
of link indices. This is a surviving FORTRANism that is quite unlike of link indices. This is a surviving FORTRANism that is quite unlike
@ -128,9 +127,6 @@ ways:
to fix it because doing so would (a) be quite difficult, and (b) to fix it because doing so would (a) be quite difficult, and (b)
compromise forward-portability to other languages. compromise forward-portability to other languages.
* The code still has an unfortunately high density of magic numbers - in
particular, numeric object IDs. There are plans to fix this.
* Much of the code still uses FORTRAN-style uppercase names. * Much of the code still uses FORTRAN-style uppercase names.
* The code still assumes one-origin array indexing. Thus, arrays are * The code still assumes one-origin array indexing. Thus, arrays are