Resolve GitLab issue #3. Applies MISRA and CERT guidelines.

MISRA C++:2008, 2-13-4 - Literal suffixes shall be upper case

MISRA C:2012, 7.3 - The lowercase character "l" shall not be used in a
literal suffix

CERT DCL16-C. - Use "L," not "l," to indicate a long value

CERT DCL16-CPP. - Use "L," not "l," to indicate a long value

CERT, DCL50-J. - Use visually distinct identifiers
This commit is contained in:
David James Sherman 2017-06-21 17:09:02 +02:00 committed by Eric S. Raymond
parent 67ed99b29c
commit 82f162dc32

View file

@ -54,7 +54,7 @@ long ACTSPK[VRBSIZ + 1];
static bool is_set(long var, long position) static bool is_set(long var, long position)
{ {
long mask = 1l << position; long mask = 1L << position;
bool result = (var & mask) == mask; bool result = (var & mask) == mask;
return (result); return (result);
} }
@ -308,7 +308,7 @@ static void read_conditions(FILE* database)
while ((loc = GETNUM(NULL)) != 0) { while ((loc = GETNUM(NULL)) != 0) {
if (is_set(COND[loc], K)) if (is_set(COND[loc], K))
BUG(LOCATION_HAS_CONDITION_BIT_BEING_SET_TWICE); BUG(LOCATION_HAS_CONDITION_BIT_BEING_SET_TWICE);
COND[loc] = COND[loc] + (1l << K); COND[loc] = COND[loc] + (1L << K);
} }
} }
} }