archives/open-adventure
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Adjust for Peje Add Peje Nilsson to credits.

Browse source
This commit is contained in:
Eric S. Raymond 2017-06-13 07:49:53 -04:00
parent a7c0f331d1
commit 9e08cba63e
1 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
notes.adoc
View file

@ -9,7 +9,9 @@ separate link:history.html[history] describing how it came to us.
The principal maintainers of this code are Eric S. Raymond and Jason The principal maintainers of this code are Eric S. Raymond and Jason
Ninneman. Eric received Don Woods's encouragement to update and ship Ninneman. Eric received Don Woods's encouragement to update and ship
the game; Jason signed on early in the process to help. the game; Jason signed on early in the process to help. The assistance
of Peje Nilson in restructuring some particularly grotty gotos is
gratefully acknowledged.
== Nomenclature == == Nomenclature ==
@ -81,7 +83,7 @@ against a comprehesive test suite that we built first and verified with
coverage tools. This is what you are running when you do "make check". coverage tools. This is what you are running when you do "make check".
This move entailed some structural changes. The most important was This move entailed some structural changes. The most important was
the refactoring of 355 gotos into if/loop/break structures. We the refactoring of over 350 gotos into if/loop/break structures. We
also abolished almost all shared globals; the main one left is a also abolished almost all shared globals; the main one left is a
struct holding the game's saveable/restorable state. struct holding the game's saveable/restorable state.
@ -108,10 +110,10 @@ ways:
and the choice to refrain will make forward translation into future and the choice to refrain will make forward translation into future
languages easier. languages easier.
* There are 19 gotos left that resist restructuring; all of these are * There are some gotos left that resist restructuring; all of these
in the principal command interpreter function implementing its state are in the principal command interpreter function implementing its
machine. A 21st, a two-level loop breakout, is not reducible even state machine. One other left in the player-movement code, a two-level
in principle. loop breakout, is not reducible even in principle.
* Linked lists (for objects at a location) are implemented using an array * Linked lists (for objects at a location) are implemented using an array
of link indices. This is a surviving FORTRANism that is quite unlike of link indices. This is a surviving FORTRANism that is quite unlike