archives/open-adventure
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Close out oldcompare.

Browse source 
At this revision all test logs either pass checkfile comparison
against advent439 or have a NOCOMPARE comment explaining why they don't
pass, turning into a TAP skip. 100% coverage.
This commit is contained in:
Eric S. Raymond 2023-04-01 18:14:25 -04:00
parent 59a5afb72e
commit e49fb5f367
15 changed files with 19 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/Makefile
View file

@ -163,6 +163,10 @@ oldcompare: $(SGAMES)
fi; \ fi; \
done; \ done; \
echo 1..$(words $(shell ls *.log))) | $(TAPFILTER) echo 1..$(words $(shell ls *.log))) | $(TAPFILTER)
@rm *.ochk rm *-new advent430 adventure.data @rm *.ochk *-new advent430 adventure.data
# List all NOMPARE tests.
residuals:
@grep -n NOCOMPARE *.log
# end # end

1
tests/barehands.log
View file

@ -1,4 +1,5 @@
## Get to dragon, refuse to use bare hands ## Get to dragon, refuse to use bare hands
#NOCOMPARE Fails due uninteresting difference in whitespace process.
# Based on walkthrough at http://www.ecsoftwareconsulting.com/node/56 # Based on walkthrough at http://www.ecsoftwareconsulting.com/node/56
n n
seed 1635997320 seed 1635997320

2
tests/cheatresume.log
View file

@ -1,5 +1,5 @@
## Resume from absurd save file with numdie = -900 ## Resume from absurd save file with numdie = -900
#NOCOMPARE Can't compare to asvent430 die to version skew #NOCOMPARE Can't compare to asvent430 due to version skew
n n
resume resume
cheat_numdie.adv cheat_numdie.adv

2
tests/cheatresume2.log
View file

@ -1,6 +1,6 @@
## Resume from absurd save file with numdie = -1000 ## Resume from absurd save file with numdie = -1000
# generating "off my scale" score threshold message # generating "off my scale" score threshold message
#NOCOMPARE Can't compare to asvent430 die to version skew #NOCOMPARE Can't compare to asvent430 due to version skew
n n
resume resume
cheat_numdie1000.adv cheat_numdie1000.adv

1
tests/fail_hint_ogre.log
View file

@ -1,4 +1,5 @@
## Qualify for ogre hint but fail due to dwarves dead (fuzzed) ## Qualify for ogre hint but fail due to dwarves dead (fuzzed)
#NOCOMPARE Fails due uninteresting difference in whitespace process.
n n
seed 1838473132 seed 1838473132
in in

2
tests/flyback.log
View file

@ -1,4 +1,4 @@
## Test fix for issue #51: rug flying is broken ## Test fix for issue 51: rug flying is broken
#NOCOMPARE Behavior differs due to a bug fix. #NOCOMPARE Behavior differs due to a bug fix.
n n
seed 1838473132 seed 1838473132

1
tests/goback.log
View file

@ -1,6 +1,7 @@
## Test many nonlethal failure conditions ## Test many nonlethal failure conditions
# This variant elicits the prompt to go back for batteries # This variant elicits the prompt to go back for batteries
# See comments in this log # See comments in this log
#NOCOMPARE Relies on "waste"
n n
seed 1838473132 seed 1838473132
in in

1
tests/oldstyle.log
View file

@ -1,5 +1,6 @@
## Simple quit ## Simple quit
#options: -o #options: -o
#NOCOMPARE Comment not interpreted by advent430
n n
i i
l l

2
tests/oysterbug.log
View file

@ -1,5 +1,5 @@
# Demonstrate fix of buggy response to unlocking oyster while carrying it. # Demonstrate fix of buggy response to unlocking oyster while carrying it.
#NOCOMPARE This fixes a bug in advent430 #NOCOMPARE This fails due to a known bug in advent430
n n
seed 1838473132 seed 1838473132
in in

2
tests/saveresume.1.log
View file

@ -1,5 +1,5 @@
## Save right after starting ## Save right after starting
#NOCOMPARE Can't compare to asvent430 die to version skew #NOCOMPARE Can't compare to asvent430 due to version skew
n n
seed 1240742801 seed 1240742801
save save

2
tests/saveresume.2.log
View file

@ -1,5 +1,5 @@
## Resume and then quit ## Resume and then quit
#NOCOMPARE Can't compate to asvent430 die to version skew #NOCOMPARE Can't compate to asvent430 due to version skew
n n
in in
resume resume

2
tests/saveresume.3.log
View file

@ -1,6 +1,6 @@
## Almost win, then save ## Almost win, then save
# Based on walkthrough at http://www.ecsoftwareconsulting.com/node/56 # Based on walkthrough at http://www.ecsoftwareconsulting.com/node/56
#NOCOMPARE seems to reveal a bug in advent430 #NOCOMPARE Seems to reveal a bug in advent430's save function.
n n
seed 1838473132 seed 1838473132
in in

2
tests/savetamper.log
View file

@ -1,5 +1,5 @@
## Resume from artificial "corrupted" save ## Resume from artificial "corrupted" save
#NOCOMPARE Can't compare to asvent430 die to version skew #NOCOMPARE Can't compare to asvent430 due to version skew
n n
resume resume
cheat_savetamper.adv cheat_savetamper.adv

1
tests/water_plant2.log
View file

@ -1,4 +1,5 @@
## Check that pour correctly switches among plant states (fuzzed) ## Check that pour correctly switches among plant states (fuzzed)
#NOCOMPARE Behavior differs due to a parser bug fix.
n n
seed 183847312 seed 183847312
in in

1
tests/woodshint.log
View file

@ -1,4 +1,5 @@
## Test hinting logic - elicit forest hint ## Test hinting logic - elicit forest hint
#NOCOMPARE Behavior differs due to a parser bug fix.
# Also some tests of intransitive-verb cases # Also some tests of intransitive-verb cases
n n
seed 2099333241 seed 2099333241