archives/open-adventure
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prevent tampering with PRNG parameters in save

Browse source
This commit is contained in:
NHOrus 2017-08-24 14:48:02 +03:00
parent 917af2e744
commit e5a0c6e2b7
2 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
main.c
View file

@ -1175,9 +1175,6 @@ Lookup:
default: // LCOV_EXCL_LINE default: // LCOV_EXCL_LINE
BUG(VOCABULARY_TYPE_N_OVER_1000_NOT_BETWEEN_0_AND_3); // LCOV_EXCL_LINE BUG(VOCABULARY_TYPE_N_OVER_1000_NOT_BETWEEN_0_AND_3); // LCOV_EXCL_LINE
} }
if (!is_valid(game)) {
exit(1);
}
switch (action(command)) { switch (action(command)) {
case GO_TERMINATE: case GO_TERMINATE:
return true; return true;

6
saveresume.c
View file

@ -139,6 +139,12 @@ bool is_valid(struct game_t valgame)
return false; return false;
} }
/* Prevent RNG substitution. Why we are saving PRNG parameters? */
if (valgame.lcg_a != game.lcg_a || valgame.lcg_c != game.lcg_c || valgame.lcg_m != game.lcg_m) {
return false;
}
/* Bounds check for locations */ /* Bounds check for locations */
if ( valgame.chloc < -1 || valgame.chloc > NLOCATIONS || if ( valgame.chloc < -1 || valgame.chloc > NLOCATIONS ||
valgame.chloc2 < -1 || valgame.chloc2 > NLOCATIONS || valgame.chloc2 < -1 || valgame.chloc2 > NLOCATIONS ||