archives/snowflake
2
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake.git synced 2025-10-13 20:11:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(probetest): maybe resource leak

Browse source 
...on failed requests: WebRTC connection wouldn't get
closed in such cases.
This commit is contained in:
WofWca 2024-09-07 15:35:49 +04:00 • committed by Shelikhoo
parent 51edbbfd26
commit 2d13e2a5d1
No known key found for this signature in database
GPG key ID: 4C9764E9FE80A3DC
1 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
probetest/probetest.go
View file

@ -141,6 +141,16 @@ func probeHandler(stunURL string, w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusInternalServerError)
return
}
// We'll set this to `false` if the signaling (this function) succeeds.
closePcOnReturn := true
defer func() {
if closePcOnReturn {
if err := pc.Close(); err != nil {
log.Printf("Error calling pc.Close: %v", err)
}
}
// Otherwise it must be closed below, wherever `closePcOnReturn` is set to `false`.
}()
sdp = &webrtc.SessionDescription{
Type: pc.LocalDescription().Type,
@ -163,6 +173,7 @@ func probeHandler(stunURL string, w http.ResponseWriter, r *http.Request) {
// Set a timeout on peerconnection. If the connection state has not
// advanced to PeerConnectionStateConnected in this time,
// destroy the peer connection and return the token.
closePcOnReturn = false
go func() {
timer := time.NewTimer(dataChannelTimeout)
defer timer.Stop()