archives/snowflake
2
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake.git synced 2025-10-14 05:11:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove erroneous logging around pt.*Error calls.

Browse source 
These functions are called for their side effect of sending a PT error
message on stdout; they also return a representation of the error
message as an error object for the caller to use if it wishes. These
functions *always* return a non-nil error object; it is not something to
be logged, any more than the return value of errors.New is.

The mistaken logging was added in
https://bugs.torproject.org/31794
b26c7a7a73
3ec9dd19fa
ed3d42e1ec
This commit is contained in:
David Fifield 2020-01-20 23:57:31 -07:00
parent 37aaaffa15
commit 5ff75e1034
3 changed files with 7 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

4
server-webrtc/snowflake.go
View file

@ -230,9 +230,7 @@ func main() {
bindaddr.Addr.Port = 12345 // lies!!!
pt.Smethod(bindaddr.MethodName, bindaddr.Addr)
default:
if err := pt.SmethodError(bindaddr.MethodName, "no such method"); err != nil {
log.Printf("SmethodError returned error: %v", err)
}
pt.SmethodError(bindaddr.MethodName, "no such method")
}
}
pt.SmethodsDone()