archives/snowflake
2
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake.git synced 2025-10-13 20:11:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

broker and proxy must not reject client offers with no ICE candidates

Browse source 
Fixes #40371. Partially reverts !141.
This commit is contained in:
Neel Chauhan 2024-10-14 13:38:20 -04:00 • committed by Cecylia Bocovich
parent 9ff205dd7f
commit 8792771cdc
No known key found for this signature in database
GPG key ID: 009DE379FD9B7B90
4 changed files with 0 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

7
proxy/lib/snowflake.go
View file

@ -545,9 +545,6 @@ func (sf *SnowflakeProxy) makePeerConnectionFromOffer(
" before the client times out")
}
if !strings.Contains(pc.LocalDescription().SDP, "\na=candidate:") {
return nil, fmt.Errorf("SDP answer contains no candidate")
}
log.Printf("Answer: \n\t%s", strings.ReplaceAll(pc.LocalDescription().SDP, "\n", "\n\t"))
return pc, nil
@ -608,10 +605,6 @@ func (sf *SnowflakeProxy) makeNewPeerConnection(
// Wait for ICE candidate gathering to complete
<-done
if !strings.Contains(pc.LocalDescription().SDP, "\na=candidate:") {
return nil, fmt.Errorf("Probetest SDP offer contains no candidate")
}
return pc, nil
}