mirror of
https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake.git
synced 2025-10-13 20:11:19 -04:00
Bug 28727: remove "broker" and "relay" query string parameters.
These could be misused to cause Snowflake proxies to attempt connect to unsuspecting third parties. https://bugs.torproject.org/28727
This commit is contained in:
parent
5817c257c1
commit
debe9c3748
1 changed files with 4 additions and 8 deletions
|
@ -11,8 +11,8 @@ TODO: More documentation
|
|||
|
||||
# General snowflake proxy constants.
|
||||
# For websocket-specific constants, see websocket.coffee.
|
||||
DEFAULT_BROKER = 'snowflake-broker.bamsoftware.com'
|
||||
DEFAULT_RELAY =
|
||||
BROKER = 'snowflake-broker.bamsoftware.com'
|
||||
RELAY =
|
||||
host: 'snowflake.bamsoftware.com'
|
||||
port: '443'
|
||||
# Original non-wss relay:
|
||||
|
@ -236,10 +236,7 @@ init = (isNode) ->
|
|||
# Hook up to the debug UI if available.
|
||||
ui = if isNode then null else new UI()
|
||||
silenceNotifications = Params.getBool(query, 'silent', false)
|
||||
# Retrieve connectivity information for the Broker and
|
||||
# initialize Snowflake contexts.
|
||||
brokerUrl = Params.getString(query, 'broker', DEFAULT_BROKER)
|
||||
broker = new Broker brokerUrl
|
||||
broker = new Broker BROKER
|
||||
snowflake = new Snowflake broker, ui
|
||||
|
||||
log '== snowflake proxy =='
|
||||
|
@ -251,8 +248,7 @@ init = (isNode) ->
|
|||
# Otherwise, begin setting up WebRTC and acting as a proxy.
|
||||
log 'Copy-Paste mode detected.' if COPY_PASTE_ENABLED
|
||||
dbg 'Contacting Broker at ' + broker.url if not COPY_PASTE_ENABLED
|
||||
relayAddr = Params.getAddress(query, 'relay', DEFAULT_RELAY)
|
||||
snowflake.setRelayAddr relayAddr
|
||||
snowflake.setRelayAddr RELAY
|
||||
snowflake.beginWebRTC()
|
||||
|
||||
# Notification of closing tab with active proxy.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue