snowflake/common
WofWca cb0fb02cd5
fix(proxy): not answering before client timeout
This is related to
https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/40230.

The initial MR that closed that issue,
https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/merge_requests/391,
was not semantically correct, because `DataChannelTimeout`
starts after the client has already received the answer.

After
https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/merge_requests/498#note_3156256
the code became not only semantically incorrect,
but also functionally incorrect because now if this timeout is hit
by the proxy, the client is guaranteed to be gone already.
This commit fixes it, by lowering the timeout.

This addresses a suggestion in
https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/40447.

This also closes
https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/issues/40381
and supersedes
https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/merge_requests/415.
2025-02-12 10:17:08 -05:00
..
amp refactor: change deprecated "io/ioutil" package to recommended "io" package 2024-02-17 12:47:22 +01:00
bridgefingerprint Represent Bridge Fingerprint As String 2022-06-16 14:06:58 +01:00
certs Add self-signed ISRG Root X1 to cert pool 2025-01-15 10:56:17 -05:00
constants fix(proxy): not answering before client timeout 2025-02-12 10:17:08 -05:00
encapsulation refactor: change deprecated "io/ioutil" package to recommended "io" package 2024-02-17 12:47:22 +01:00
event chore(deps): update module github.com/pion/webrtc/v3 to v4 2024-11-11 18:45:36 +00:00
messages refactor: use named returns for some funcs 2024-12-03 12:51:42 +00:00
namematcher Update Relay Pattern format to include dollar sign 2022-06-16 14:06:58 +01:00
nat chore(deps): update module github.com/pion/stun to v3 2024-08-27 09:43:08 -04:00
proxy update snowflake to use pion webrtc v4 2024-11-13 14:58:53 +00:00
sqsclient Add mocks and interfaces for testing SQS rendezvous 2024-01-22 13:10:56 -05:00
sqscreds Switch to sqscreds param for passing in SQS credentials 2024-03-09 13:35:16 -05:00
task Simplify proxy NAT checking logic 2024-05-28 12:30:44 -07:00
turbotunnel Revert "Move time.Sleep call in turbotunnel test" 2024-09-24 13:12:23 -04:00
util improvement: use SetIPFilter for local addrs 2024-11-28 10:56:40 -05:00
version Bump version of Snowflake to 2.10.1 2024-11-11 13:15:48 -05:00
websocketconn refactor: change deprecated "io/ioutil" package to recommended "io" package 2024-02-17 12:47:22 +01:00