From 6867c4e870f2fb3232a123eb5358ff8efeefbe24 Mon Sep 17 00:00:00 2001 From: Vicki Pfau Date: Tue, 30 Jul 2024 19:55:31 -0700 Subject: [PATCH] power: Remove inline GPU clock range check, sysfs writes enforce it --- src/manager/root.rs | 3 --- src/power.rs | 7 +------ 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/src/manager/root.rs b/src/manager/root.rs index 759adbe..5498c1b 100644 --- a/src/manager/root.rs +++ b/src/manager/root.rs @@ -487,9 +487,6 @@ mod test { proxy.set_manual_gpu_clock(200).await.expect("proxy_set"); assert_eq!(read_clocks().await.unwrap(), format_clocks(200)); - assert!(proxy.set_manual_gpu_clock(100).await.is_err()); - assert_eq!(read_clocks().await.unwrap(), format_clocks(200)); - test.connection.close().await.unwrap(); } diff --git a/src/power.rs b/src/power.rs index 7f0123f..ba2872e 100644 --- a/src/power.rs +++ b/src/power.rs @@ -275,10 +275,8 @@ pub(crate) async fn set_cpu_scaling_governor(governor: CPUScalingGovernor) -> Re } pub(crate) async fn set_gpu_clocks(clocks: u32) -> Result<()> { - // Set GPU clocks to given value valid between 200 - 1600 + // Set GPU clocks to given value valid // Only used when GPU Performance Level is manual, but write whenever called. - ensure!((200..=1600).contains(&clocks), "Invalid clocks"); - let base = find_hwmon().await?; let mut myfile = File::create(base.join(GPU_CLOCKS_SUFFIX)) .await @@ -627,9 +625,6 @@ CCLK_RANGE in Core0: assert!(set_gpu_clocks(1600).await.is_err()); setup().await; - assert!(set_gpu_clocks(100).await.is_err()); - assert!(set_gpu_clocks(2000).await.is_err()); - assert!(set_gpu_clocks(200).await.is_ok()); assert_eq!(read_clocks().await.unwrap(), format_clocks(200));