archives/steamos-manager
archives/steamos-manager
2
0
Fork 1
mirror of https://gitlab.steamos.cloud/holo/steamos-manager.git synced 2025-07-15 10:46:41 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

screenreader: Also add test for when orca settings file is missing.

Browse source 
Also use constants for filenames to reduce typo failures.
This commit is contained in:
Jeremy Whiting 2025-05-29 20:54:43 -06:00
parent 1053e0dd77
commit 8d23f01393
1 changed files with 52 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

94
src/screenreader.rs
View file

@ -22,6 +22,11 @@ use zbus::Connection;
use crate::path; use crate::path;
use crate::systemd::SystemdUnit; use crate::systemd::SystemdUnit;
#[cfg(test)]
const TEST_ORCA_SETTINGS: &str = "data/test-orca-settings.conf";
#[cfg(test)]
const ORCA_SETTINGS: &str = "orca-settings.conf";
#[cfg(not(test))] #[cfg(not(test))]
const ORCA_SETTINGS: &str = "orca/user-settings.conf"; const ORCA_SETTINGS: &str = "orca/user-settings.conf";
const PITCH_SETTING: &str = "average-pitch"; const PITCH_SETTING: &str = "average-pitch";
@ -81,7 +86,7 @@ impl<'dbus> OrcaManager<'dbus> {
#[cfg(test)] #[cfg(test)]
fn settings_path(&self) -> Result<PathBuf> { fn settings_path(&self) -> Result<PathBuf> {
Ok(path("orca-settings.conf")) Ok(path(ORCA_SETTINGS))
} }
pub fn enabled(&self) -> bool { pub fn enabled(&self) -> bool {
@ -289,21 +294,17 @@ impl<'dbus> OrcaManager<'dbus> {
mod test { mod test {
use super::*; use super::*;
use crate::testing; use crate::testing;
use tokio::fs::copy; use tokio::fs::{copy, remove_file};
#[tokio::test] #[tokio::test]
async fn test_enable_disable() { async fn test_enable_disable() {
let mut h = testing::start(); let mut h = testing::start();
copy( copy(TEST_ORCA_SETTINGS, h.test.path().join(ORCA_SETTINGS))
"data/test-orca-settings.conf", .await
h.test.path().join("orca-settings.conf"), .unwrap();
) let mut manager = OrcaManager::new(&h.new_dbus().await.expect("new_dbus"))
.await .await
.unwrap(); .expect("OrcaManager::new");
let mut manager =
OrcaManager::new(&h.new_dbus().await.expect("new_dbus"))
.await
.expect("OrcaManager::new");
let enable_result = manager.set_enabled(true).await; let enable_result = manager.set_enabled(true).await;
assert!(enable_result.is_ok()); assert!(enable_result.is_ok());
assert_eq!(manager.enabled(), true); assert_eq!(manager.enabled(), true);
@ -316,16 +317,12 @@ mod test {
#[tokio::test] #[tokio::test]
async fn test_pitch() { async fn test_pitch() {
let mut h = testing::start(); let mut h = testing::start();
copy( copy(TEST_ORCA_SETTINGS, h.test.path().join(ORCA_SETTINGS))
"data/test-orca-settings.conf", .await
h.test.path().join("orca-settings.conf"), .unwrap();
) let mut manager = OrcaManager::new(&h.new_dbus().await.expect("new_dbus"))
.await .await
.unwrap(); .expect("OrcaManager::new");
let mut manager =
OrcaManager::new(&h.new_dbus().await.expect("new_dbus"))
.await
.expect("OrcaManager::new");
let set_result = manager.set_pitch(5.0).await; let set_result = manager.set_pitch(5.0).await;
assert!(set_result.is_ok()); assert!(set_result.is_ok());
assert_eq!(manager.pitch(), 5.0); assert_eq!(manager.pitch(), 5.0);
@ -337,21 +334,24 @@ mod test {
let too_high_result = manager.set_pitch(12.0).await; let too_high_result = manager.set_pitch(12.0).await;
assert!(too_high_result.is_err()); assert!(too_high_result.is_err());
assert_eq!(manager.pitch(), 5.0); assert_eq!(manager.pitch(), 5.0);
remove_file(h.test.path().join(ORCA_SETTINGS))
.await
.unwrap();
let nofile_result = manager.set_pitch(7.0).await;
assert_eq!(manager.pitch(), 5.0);
assert!(nofile_result.is_err());
} }
#[tokio::test] #[tokio::test]
async fn test_rate() { async fn test_rate() {
let mut h = testing::start(); let mut h = testing::start();
copy( copy(TEST_ORCA_SETTINGS, h.test.path().join(ORCA_SETTINGS))
"data/test-orca-settings.conf", .await
h.test.path().join("orca-settings.conf"), .unwrap();
) let mut manager = OrcaManager::new(&h.new_dbus().await.expect("new_dbus"))
.await .await
.unwrap(); .expect("OrcaManager::new");
let mut manager =
OrcaManager::new(&h.new_dbus().await.expect("new_dbus"))
.await
.expect("OrcaManager::new");
let set_result = manager.set_rate(5.0).await; let set_result = manager.set_rate(5.0).await;
assert!(set_result.is_ok()); assert!(set_result.is_ok());
assert_eq!(manager.rate(), 5.0); assert_eq!(manager.rate(), 5.0);
@ -363,21 +363,24 @@ mod test {
let too_high_result = manager.set_rate(101.0).await; let too_high_result = manager.set_rate(101.0).await;
assert!(too_high_result.is_err()); assert!(too_high_result.is_err());
assert_eq!(manager.rate(), 5.0); assert_eq!(manager.rate(), 5.0);
remove_file(h.test.path().join(ORCA_SETTINGS))
.await
.unwrap();
let nofile_result = manager.set_rate(7.0).await;
assert_eq!(manager.rate(), 5.0);
assert!(nofile_result.is_err());
} }
#[tokio::test] #[tokio::test]
async fn test_volume() { async fn test_volume() {
let mut h = testing::start(); let mut h = testing::start();
copy( copy(TEST_ORCA_SETTINGS, h.test.path().join(ORCA_SETTINGS))
"data/test-orca-settings.conf", .await
h.test.path().join("orca-settings.conf"), .unwrap();
) let mut manager = OrcaManager::new(&h.new_dbus().await.expect("new_dbus"))
.await .await
.unwrap(); .expect("OrcaManager::new");
let mut manager =
OrcaManager::new(&h.new_dbus().await.expect("new_dbus"))
.await
.expect("OrcaManager::new");
let set_result = manager.set_volume(5.0).await; let set_result = manager.set_volume(5.0).await;
assert!(set_result.is_ok()); assert!(set_result.is_ok());
assert_eq!(manager.volume(), 5.0); assert_eq!(manager.volume(), 5.0);
@ -389,5 +392,12 @@ mod test {
let too_high_result = manager.set_volume(12.0).await; let too_high_result = manager.set_volume(12.0).await;
assert!(too_high_result.is_err()); assert!(too_high_result.is_err());
assert_eq!(manager.volume(), 5.0); assert_eq!(manager.volume(), 5.0);
remove_file(h.test.path().join(ORCA_SETTINGS))
.await
.unwrap();
let nofile_result = manager.set_volume(7.0).await;
assert_eq!(manager.volume(), 5.0);
assert!(nofile_result.is_err());
} }
} }