From b16552ff24c07ead0d7975004e1de9f4ab70b79f Mon Sep 17 00:00:00 2001 From: Scott Lessans Date: Tue, 5 Aug 2025 10:36:49 -0700 Subject: [PATCH] cleanup flags and platforms --- .github/workflows/CI.yml | 12 ++++-------- README.md | 4 ++-- pyproject.toml | 2 +- test_python.sh | 2 +- 4 files changed, 8 insertions(+), 12 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index c5a0264..29518e7 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -32,10 +32,6 @@ jobs: target: aarch64 - runner: ubuntu-22.04 target: armv7 - # - runner: ubuntu-22.04 - # target: s390x - # - runner: ubuntu-22.04 - # target: ppc64le steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v5 @@ -48,7 +44,7 @@ jobs: CFLAGS_aarch64_unknown_linux_gnu: -D__ARM_ARCH=8 with: target: ${{ matrix.platform.target }} - args: -F python-binding --release --out dist --find-interpreter + args: --release --out dist --find-interpreter sccache: ${{ !startsWith(github.ref, 'refs/tags/') }} manylinux: auto - name: Upload wheels @@ -82,7 +78,7 @@ jobs: CFLAGS_aarch64_unknown_linux_musl: -D__ARM_ARCH=8 with: target: ${{ matrix.platform.target }} - args: -F python-binding --release --out dist --find-interpreter + args: --release --out dist --find-interpreter sccache: ${{ !startsWith(github.ref, 'refs/tags/') }} manylinux: musllinux_1_2 - name: Upload wheels @@ -110,7 +106,7 @@ jobs: uses: PyO3/maturin-action@v1 with: target: ${{ matrix.platform.target }} - args: -F python-binding --release --out dist --find-interpreter + args: --release --out dist --find-interpreter sccache: ${{ !startsWith(github.ref, 'refs/tags/') }} - name: Upload wheels uses: actions/upload-artifact@v4 @@ -136,7 +132,7 @@ jobs: uses: PyO3/maturin-action@v1 with: target: ${{ matrix.platform.target }} - args: -F python-binding --release --out dist --find-interpreter + args: --release --out dist --find-interpreter sccache: ${{ !startsWith(github.ref, 'refs/tags/') }} - name: Upload wheels uses: actions/upload-artifact@v4 diff --git a/README.md b/README.md index 1b9d4f4..6ce4885 100644 --- a/README.md +++ b/README.md @@ -177,10 +177,10 @@ source .venv/bin/activate # Install maturin and test dependencies pip install maturin pytest mypy ruff # tailor to your workflow # Compile the Rust crate *and* install the Python package in editable mode -maturin develop -F python-binding --release +maturin develop --release ``` -`maturin develop -F python-binding` builds _harmony_ with Cargo, produces a native extension +`maturin develop` builds _harmony_ with Cargo, produces a native extension (`openai_harmony..so`) and places it in your virtualenv next to the pure- Python wrapper – similar to `pip install -e .` for pure Python projects. diff --git a/pyproject.toml b/pyproject.toml index 5836c58..4c8ad8c 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -16,7 +16,7 @@ description = "OpenAI's response format for its open-weight model series gpt-oss readme = "README.md" [project.optional-dependencies] -demo = [] +demo = ["uvicorn", "fastapi"] [tool.maturin] features = ["python-binding", "pyo3/extension-module"] diff --git a/test_python.sh b/test_python.sh index 09a24de..51176a7 100755 --- a/test_python.sh +++ b/test_python.sh @@ -1,5 +1,5 @@ #!/usr/bin/env bash set -e source .venv/bin/activate -maturin develop -F python-binding --release +maturin develop --release pytest "$@"