Fix luacheck warnings in gui.lua

This commit is contained in:
Athozus 2023-03-14 12:41:54 +01:00
parent 8d9c1aa43f
commit c0c3692c2b
No known key found for this signature in database
GPG key ID: B50895022E8484BF

23
gui.lua
View file

@ -412,7 +412,7 @@ function mail.show_message(name, msgnumber)
local body = minetest.formspec_escape(message.body) or "" local body = minetest.formspec_escape(message.body) or ""
formspec = string.format(formspec, from, to, cc, date, subject, body) formspec = string.format(formspec, from, to, cc, date, subject, body)
message_status = mail.getMessageStatus(name, message.id) local message_status = mail.getMessageStatus(name, message.id)
if message_status == "unread" then if message_status == "unread" then
mail.setStatus(name, message.id, "read") mail.setStatus(name, message.id, "read")
@ -508,7 +508,7 @@ function mail.handle_receivefields(player, formname, fields)
elseif formname == "mail:inbox" or formname == "mail:sent" then elseif formname == "mail:inbox" or formname == "mail:sent" then
local name = player:get_player_name() local name = player:get_player_name()
local messages = mail.getPlayerMessages(name) -- split inbox and sent msgs for different tests
local messagesInbox = mail.getPlayerInboxMessages(name) local messagesInbox = mail.getPlayerInboxMessages(name)
local messagesSent = mail.getPlayerSentMessages(name) local messagesSent = mail.getPlayerSentMessages(name)
@ -642,26 +642,29 @@ function mail.handle_receivefields(player, formname, fields)
return true -- don't uselessly set messages return true -- don't uselessly set messages
elseif fields.reply then elseif fields.reply then
local message = ""
if messagesInbox[selected_idxs.inbox[name]] then if messagesInbox[selected_idxs.inbox[name]] then
local message = messagesInbox[selected_idxs.inbox[name]] message = messagesInbox[selected_idxs.inbox[name]]
elseif messagesSent[selected_idxs.sent[name]] then elseif messagesSent[selected_idxs.sent[name]] then
local message = messagesSent[selected_idxs.sent[name]] message = messagesSent[selected_idxs.sent[name]]
end end
mail.reply(name, message) mail.reply(name, message)
elseif fields.replyall then elseif fields.replyall then
local message = ""
if messagesInbox[selected_idxs.inbox[name]] then if messagesInbox[selected_idxs.inbox[name]] then
local message = messagesInbox[selected_idxs.inbox[name]] message = messagesInbox[selected_idxs.inbox[name]]
elseif messagesSent[selected_idxs.sent[name]] then elseif messagesSent[selected_idxs.sent[name]] then
local message = messagesSent[selected_idxs.sent[name]] message = messagesSent[selected_idxs.sent[name]]
end end
mail.replyall(name, message) mail.replyall(name, message)
elseif fields.forward then elseif fields.forward then
local message = ""
if messagesInbox[selected_idxs.inbox[name]] then if messagesInbox[selected_idxs.inbox[name]] then
local message = messagesInbox[selected_idxs.inbox[name]] message = messagesInbox[selected_idxs.inbox[name]]
elseif messagesSent[selected_idxs.sent[name]] then elseif messagesSent[selected_idxs.sent[name]] then
local message = messagesSent[selected_idxs.sent[name]] message = messagesSent[selected_idxs.sent[name]]
end end
mail.forward(name, message) mail.forward(name, message)
@ -701,11 +704,11 @@ function mail.handle_receivefields(player, formname, fields)
local contacts = mail.getPlayerContacts(name) local contacts = mail.getPlayerContacts(name)
local recipients = mail.parse_player_list(fields.to) local recipients = mail.parse_player_list(fields.to)
local isNew = true local isNew = true
for r_,recipient in ipairs(recipients) do for _,recipient in ipairs(recipients) do
if recipient:split("@")[1] == "" then -- in case of maillist if recipient:split("@")[1] == "" then -- in case of maillist
isNew = false isNew = false
else else
for c_,contact in ipairs(contacts) do for _,contact in ipairs(contacts) do
if contact.name == recipient then if contact.name == recipient then
isNew = false isNew = false
break break