standardebooks/web
1
0
Fork 0
mirror of https://github.com/standardebooks/web.git synced 2025-07-08 15:50:29 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Style tweaks for getters and add more type hinting

Browse source
This commit is contained in:
Alex Cabal 2024-04-30 22:45:20 -05:00
parent 9e31ed1aac
commit 50efeb05d1
13 changed files with 87 additions and 84 deletions
Download patch file Download diff file Expand all files Collapse all files

21
lib/User.php
View file

@ -107,6 +107,9 @@ class User extends Accessor{
// ORM METHODS
// ***********
/**
* @throws Exceptions\UserNotFoundException
*/
public static function Get(?int $userId): User{
if($userId === null){
throw new Exceptions\UserNotFoundException();
@ -118,13 +121,12 @@ class User extends Accessor{
where UserId = ?
', [$userId], 'User');
if(sizeof($result) == 0){
throw new Exceptions\UserNotFoundException();
}
return $result[0];
return $result[0] ?? throw new Exceptions\UserNotFoundException();
}
/**
* @throws Exceptions\UserNotFoundException
*/
public static function GetByEmail(?string $email): User{
if($email === null){
throw new Exceptions\UserNotFoundException();
@ -136,13 +138,12 @@ class User extends Accessor{
where Email = ?
', [$email], 'User');
if(sizeof($result) == 0){
throw new Exceptions\UserNotFoundException();
}
return $result[0];
return $result[0] ?? throw new Exceptions\UserNotFoundException();
}
/**
* @throws Exceptions\UserNotFoundException
*/
public static function GetIfRegistered(?string $identifier, ?string $password = null): User{
// We consider a user "registered" if they have a row in the Benefits table.
// Emails without that row may only be signed up for the newsletter and thus are not "registered" users