standardebooks/web
1
0
Fork 0
mirror of https://github.com/standardebooks/web.git synced 2025-07-06 14:50:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Change tag type from string to enum (TagType)

Browse source
This commit is contained in:
Mike Colagrosso 2024-10-03 13:39:33 -06:00 • committed by Alex Cabal
parent 59eee3cc57
commit 5b1bb2a9f0
6 changed files with 26 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/ArtworkTag.php
View file

@ -4,7 +4,7 @@ use function Safe\preg_replace;
class ArtworkTag extends Tag{
public function __construct(){
$this->Type = 'artwork';
$this->Type = TagType::Artwork;
}
// *******
@ -45,7 +45,7 @@ class ArtworkTag extends Tag{
$error->Add(new Exceptions\InvalidArtworkTagNameException());
}
if($this->Type != 'artwork'){
if($this->Type != TagType::Artwork){
$error->Add(new Exceptions\InvalidArtworkTagTypeException($this->Type));
}
@ -76,8 +76,8 @@ class ArtworkTag extends Tag{
SELECT *
from Tags
where Name = ?
and Type = "artwork"
', [$artworkTag->Name], ArtworkTag::class);
and Type = ?
', [$artworkTag->Name, TagType::Artwork], ArtworkTag::class);
if(isset($result[0])){
return $result[0];

7
lib/EbookTag.php
View file

@ -1,7 +1,7 @@
<?
class EbookTag extends Tag{
public function __construct(){
$this->Type = 'ebook';
$this->Type = TagType::Ebook;
}
// *******
@ -37,7 +37,7 @@ class EbookTag extends Tag{
$error->Add(new Exceptions\StringTooLongException('Ebook tag: '. $this->Name));
}
if($this->Type != 'ebook'){
if($this->Type != TagType::Ebook){
$error->Add(new Exceptions\InvalidEbookTagTypeException($this->Type));
}
@ -69,7 +69,8 @@ class EbookTag extends Tag{
SELECT *
from Tags
where Name = ?
', [$name], EbookTag::class);
and Type = ?
', [$name, TagType::Ebook], EbookTag::class);
if(isset($result[0])){
return $result[0];

10
lib/Exceptions/InvalidArtworkTagTypeException.php
View file

@ -1,13 +1,15 @@
<?
namespace Exceptions;
use \TagType;
class InvalidArtworkTagTypeException extends AppException{
/** @var string $message */
protected $message = 'Type should be `artwork`.';
protected $message = 'Type should be `TagType::Artwork`.';
public function __construct(?string $tagType){
if($tagType !== null && trim($tagType) != ''){
$this->message .= ' Type provided: ' . $tagType;
public function __construct(?TagType $tagType){
if($tagType !== null){
$this->message .= ' Type provided: ' . $tagType->value;
}
parent::__construct($this->message);

10
lib/Exceptions/InvalidEbookTagTypeException.php
View file

@ -1,13 +1,15 @@
<?
namespace Exceptions;
use \TagType;
class InvalidEbookTagTypeException extends AppException{
/** @var string $message */
protected $message = 'Type should be `ebook`.';
protected $message = 'Type should be `TagType::Ebook`.';
public function __construct(?string $tagType){
if($tagType !== null && trim($tagType) != ''){
$this->message .= ' Type provided: ' . $tagType;
public function __construct(?TagType $tagType){
if($tagType !== null){
$this->message .= ' Type provided: ' . $tagType->value;
}
parent::__construct($this->message);

2
lib/Tag.php
View file

@ -8,7 +8,7 @@ class Tag{
public int $TagId;
public string $Name;
public string $Type;
public TagType $Type;
protected ?string $_UrlName = null;
protected ?string $_Url = null;
}

5
lib/TagType.php Normal file
View file

@ -0,0 +1,5 @@
<?
enum TagType: string{
case Artwork = 'artwork';
case Ebook = 'ebook';
}