PHPStan corrections

This commit is contained in:
Alex Cabal 2025-05-07 22:01:48 -05:00
parent 30cd00dbb7
commit afab78af46
32 changed files with 77 additions and 40 deletions

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
$artist = null;

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
$isReviewerView = Session::$User?->Benefits->CanReviewArtwork ?? false;

View file

@ -1,4 +1,6 @@
<?
use function Safe\session_start;
try{
session_start();
$httpMethod = HttpInput::ValidateRequestMethod([Enums\HttpMethod::Delete]);

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
try{

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
session_start();

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
try{

View file

@ -1,9 +1,11 @@
<?
use function Safe\session_start;
try{
session_start();
$httpMethod = HttpInput::ValidateRequestMethod([Enums\HttpMethod::Post, Enums\HttpMethod::Patch, Enums\HttpMethod::Put]);
$exceptionRedirectUrl = '/artworks/new';
$artwork = new Artwork();
if(HttpInput::IsRequestTooLarge()){
throw new Exceptions\InvalidRequestException('File upload too large.');
@ -18,8 +20,6 @@ try{
if(!Session::$User->Benefits->CanUploadArtwork){
throw new Exceptions\InvalidPermissionsException();
}
$artwork = new Artwork();
$artwork->FillFromHttpPost();
$artwork->SubmitterUserId = Session::$User->UserId ?? null;
@ -54,8 +54,6 @@ try{
$exceptionRedirectUrl = $originalArtwork->EditUrl;
$artwork = new Artwork();
try{
$artwork->FillFromHttpPost();
}

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
session_start();

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
session_start();

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
session_start();

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
/** @var string $identifier Passed from script this is included from. */
$ebook = null;

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
use Gregwar\Captcha\CaptchaBuilder;

View file

@ -1,4 +1,6 @@
<?
use function Safe\session_start;
session_start();
$subscription = new NewsletterSubscription();

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function \Safe\session_unset;
session_start();

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
session_start();

View file

@ -1,5 +1,6 @@
<?
use Ramsey\Uuid\Uuid;
use function Safe\session_start;
use function Safe\session_unset;
try{

View file

@ -3,6 +3,7 @@
// we don't want to reveal the vote ID to the web browser. It should only be sent via email
// confirmation link.
use function Safe\session_start;
use function \Safe\session_unset;
session_start();

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
session_start();

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
session_start();

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
try{

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
session_start();

View file

@ -1,7 +1,6 @@
<?
use PhpParser\Node\Stmt\For_;
use function Safe\session_start;
use function Safe\session_unset;
try{

View file

@ -4,6 +4,7 @@
* GET /projects/new
*/
use function Safe\session_start;
use function Safe\session_unset;
session_start();

View file

@ -1,5 +1,7 @@
<?
use function Safe\session_start;
try{
session_start();

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
session_start();

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
try{

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
try{

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
use function Safe\session_unset;
session_start();

View file

@ -1,4 +1,5 @@
<?
use function Safe\session_start;
try{
session_start();