From a4e03c3f6ef5d4e13dc96c308901a5a24007d49b Mon Sep 17 00:00:00 2001 From: Zero Fanker Date: Wed, 10 Apr 2024 21:34:55 -0400 Subject: [PATCH] definition optimized . --- MissionEditor/MapData.cpp | 9 ++++++--- MissionEditor/MapData.h | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/MissionEditor/MapData.cpp b/MissionEditor/MapData.cpp index 7d8ef96..3b0ccf2 100644 --- a/MissionEditor/MapData.cpp +++ b/MissionEditor/MapData.cpp @@ -3814,10 +3814,13 @@ void CMapData::UpdateTreeInfo(const CString* lpTreeType) } } -int CMapData::GetBuildingID(LPCSTR lpBuildingName) +int CMapData::GetBuildingID(const CString& lpBuildingName) { - if (buildingid.find(lpBuildingName) == buildingid.end()) return -1; - return buildingid[lpBuildingName]; + auto const it = buildingid.find(lpBuildingName); + if (it == buildingid.end()) { + return -1; + } + return it->second; } diff --git a/MissionEditor/MapData.h b/MissionEditor/MapData.h index 11c9ae6..63f06ba 100644 --- a/MissionEditor/MapData.h +++ b/MissionEditor/MapData.h @@ -399,7 +399,7 @@ public: } - int GetBuildingID(LPCSTR lpBuildingName); + int GetBuildingID(const CString& lpBuildingName); void ImportRUL(LPCTSTR lpFilename); void ExportRulesChanges(const char* filename); void DeleteRulesSections();