Aaron Traas
f3dae6ff83
Coverage -- more odd actions
2017-07-04 17:41:42 -04:00
Aaron Traas
19127d05df
Removed equivocation between ROD and ROD2 in throw()
...
Already dealt with in action(), so redundant and unreachable here.
2017-07-04 17:13:26 -04:00
Eric S. Raymond
abf820bb5c
Magic-number elimination.
2017-07-04 14:40:10 -04:00
Eric S. Raymond
f37a413524
Magic-number elimination.
2017-07-04 14:15:20 -04:00
Eric S. Raymond
a8ac2f477a
Abstract out some state arithmetic.
2017-07-04 13:41:12 -04:00
NHOrus
4ac9df527b
Test for filling full bottle with different liquid
2017-07-04 20:35:03 +03:00
NHOrus
63396e6abc
Oops. Also, sometimes it's better be explicit in parameters
2017-07-04 19:50:19 +03:00
NHOrus
92de4856a6
Localized spk in discard
2017-07-04 19:45:00 +03:00
NHOrus
733b035933
Completed unspk'ing of vcarry.
2017-07-04 19:41:06 +03:00
NHOrus
e46cbdf194
Unspk'd (v)carry. Made logic more visible.
...
And tested some of newly exposed cases.
2017-07-04 19:30:22 +03:00
NHOrus
665103410a
Unspk'd and streamlined attack. Tested one of discovered gaps.
2017-07-04 18:41:28 +03:00
Aaron Traas
16a175bbab
Eliminated bivalve function.
...
Reason: only called in lock(), you can't be TOTING a clam, you can't
have the trident at a carryable oyster, and the code IMHO is more
readable this way.
2017-07-04 10:06:41 -04:00
Eric S. Raymond
e1cca3b28a
State-arithmetic elimination.
2017-07-04 09:17:20 -04:00
Eric S. Raymond
e31e69b172
Grammar fix.
2017-07-04 09:04:10 -04:00
NHOrus
e1d9c97118
Drinking not from stream gets the same result
2017-07-04 15:18:49 +03:00
NHOrus
dc34ac3d06
workaround for eat grate bug in retrospective tests
2017-07-04 15:18:49 +03:00
NHOrus
85f918f9c0
Unspk'd chain action
2017-07-04 15:18:49 +03:00
NHOrus
469a0e74ed
linearized drink
2017-07-04 15:18:49 +03:00
NHOrus
3c636e27e2
linearized extinguish
2017-07-04 15:18:49 +03:00
NHOrus
8cbb8afcbe
Unspk'd and restructured fill
2017-07-04 15:18:49 +03:00
NHOrus
e6efd6dbac
Partial cleanup of fill
2017-07-04 15:18:49 +03:00
NHOrus
294f2b8a6d
Removed magic from checks for liquids
2017-07-04 15:18:49 +03:00
NHOrus
de5696431d
Unspk'd find
2017-07-04 15:18:49 +03:00
NHOrus
ffd08893dd
Unspk'd inventory lookup
2017-07-04 15:18:49 +03:00
NHOrus
b8def22d24
Unspk'd lock, cleaned up logic
2017-07-04 15:18:49 +03:00
NHOrus
babf08ddc4
Cleaned up unused variables
2017-07-04 15:18:49 +03:00
NHOrus
df2830598c
Unspk'd Giant Words
2017-07-04 15:18:49 +03:00
Eric S. Raymond
248fc90e3d
Another use of state_change().
2017-07-04 08:16:10 -04:00
Eric S. Raymond
e91b8c2a06
Another use of state_change() and changes messages.
2017-07-04 07:59:20 -04:00
Eric S. Raymond
e62e4f6e46
YAML cleanup.
2017-07-04 07:39:07 -04:00
Jason S. Ninneman
4f78dfea24
Begin replacing tests on strings with tests on vocab IDs.
2017-07-03 18:21:25 -07:00
Jason S. Ninneman
07e7b8131e
Upgrade get_vocab_id() to handle empty strings.
2017-07-03 18:08:04 -07:00
Eric S. Raymond
659f797d8a
Implement and document new state-label syntax.
2017-07-03 20:27:56 -04:00
Eric S. Raymond
217f05b28b
Comment polishing.
2017-07-03 19:26:32 -04:00
Eric S. Raymond
1c4fcaf43e
Discard implementation of %L and %U format specifiers, now never used.
2017-07-03 18:40:06 -04:00
Eric S. Raymond
df36b62c74
Reducing use of dynamic allocation forecloses many errors.
2017-07-03 17:53:25 -04:00
Eric S. Raymond
6e67222206
Information hiding.
2017-07-03 17:21:06 -04:00
Eric S. Raymond
4b51b06b73
Simplify tokenization code.
2017-07-03 17:13:28 -04:00
Eric S. Raymond
393010ec41
Entirely eliminate wd1x and wd2x members of the command block.
...
In the process, fix another case-smashing bug.
2017-07-03 16:49:33 -04:00
NHOrus
f52a78a1f8
Captured output of help and info commands
...
Can't believe it wasn't done before
2017-07-03 22:15:19 +03:00
Eric S. Raymond
3d511d9e66
Use DOWN rather thabnd D in YAML.
2017-07-03 14:55:34 -04:00
Eric S. Raymond
a768555312
Use the raw buffer in tr command structure for editing.
...
This fixes some minor bugs. Unknown words are no longer truncated
nor uppercased on echo.
2017-07-03 12:52:28 -04:00
Eric S. Raymond
854e21a1af
Remove a bad command from a check log.
...
It's interfering with a refactor, and pathological cases really
ought to be checked elsewhere.
2017-07-03 10:10:14 -04:00
Eric S. Raymond
f03bde268e
Refactor tokenization to save raw tokens and use static buffer space...
...
...rather than dynamic storage.
As a side effect, this seems to have fixed a very ninor bug in the processing
of the bare word 'nothing'. But I don't know where the bug was. Not happy.
2017-07-03 08:53:10 -04:00
Eric S. Raymond
eba8015059
Magic-number elimination.
2017-07-03 07:14:15 -04:00
Eric S. Raymond
f48ec1eb36
Named state labels for every not clause.
2017-07-03 07:00:42 -04:00
Eric S. Raymond
bf209577a5
Make the YAML less fussy.
...
Don't string-quote things that are semantically like enums.
2017-07-03 06:47:30 -04:00
Eric S. Raymond
7740b163c8
playermove() never returns false; simplify accordingly
2017-07-03 06:10:52 -04:00
NHOrus
f8166fdb89
Visit room with breathtaking view
...
Try to extinguish a volcano
Closes #22
2017-07-03 07:30:53 +03:00
NHOrus
63152e6714
Broke all logical or into multiline statement to show lcov's lies
...
Results are weird, some things that need to be checked aren't and
at least my local lcov doesn't show them as unchecked
2017-07-03 07:20:37 +03:00
