Commit graph

886 commits

Author SHA1 Message Date
Eric S. Raymond
f50e984cec Add test for "cage bird". 2017-06-20 09:32:35 -04:00
Eric S. Raymond
521033165b Polish help text. 2017-06-20 08:41:06 -04:00
Eric S. Raymond
73f3831294 Add -l to coverage testing. 2017-06-20 08:34:01 -04:00
Eric S. Raymond
62ab37d3e9 Documentation update. 2017-06-20 08:20:34 -04:00
Eric S. Raymond
018ca9ae37 Fix off-by-one error that enabled the fuzzer to find a crash hole.
One has to allocate space for the trailing NUL, too.
2017-06-20 07:20:03 -04:00
Eric S. Raymond
d747d43429 Test logic for lamp dimming triggering battery replacement. 2017-06-20 06:52:52 -04:00
Peje Nilsson
4b93fb327a Merge branch 'master' into magic-number 2017-06-20 00:06:49 +02:00
Jason S. Ninneman
6ecd001093 Fix typo and compiler warning. 2017-06-19 14:49:15 -07:00
Jason S. Ninneman
ba64c57eb0 Add token_to_packed() utility function. 2017-06-19 14:45:32 -07:00
Peje Nilsson
c84d370918 Merge branch 'master' into magic-number 2017-06-19 23:44:48 +02:00
Peje Nilsson
f9be57a9f9 Cleanup Arithmetic on message number 2017-06-19 23:44:03 +02:00
Aaron Traas
9c88649cd4 Test coverage More misuse of transitive verbs 2017-06-19 17:33:32 -04:00
Aaron Traas
7ae0782b25 Test coverage - failure to fill 2017-06-19 17:33:32 -04:00
Aaron Traas
08c0524ee3 Test coverage -- intransitive carry when one object is present 2017-06-19 17:33:32 -04:00
Aaron Traas
7753ad3134 Test coverage - drink with no valid object 2017-06-19 17:33:32 -04:00
Eric S. Raymond
a678b68b39 Mostly confine assumptions about what token_t is to misc.c
The token_t things like WD* are presently longs and will someday be
char[6].  By introducing some trivial functions - wordeq(),
wordempty(), and wordclear() - we mostly hide the difference.

All runtime knowledge about packing now lives only in misc.c and the
list of magic WORD_* defines in advent.h.  Outside this, literals are
now accessed through #define names that could expand to either longs
or strings.

Still to be done: WD* values are sometiimes compated to zero in
ways implying they can be negative. Must figure out wat thus means.
2017-06-19 17:21:45 -04:00
Eric S. Raymond
87961483a2 Concentrate all magic-number values for packed-string constants in one place. 2017-06-19 16:53:55 -04:00
Eric S. Raymond
79f5701e07 More semantic typing - a step towards eliminating packing. 2017-06-19 14:20:45 -04:00
Aaron Traas
f4ac82b9f8 Really 100% test coverage for saveresume.c 2017-06-19 13:55:04 -04:00
Aaron Traas
43247f995b Should have 100% coverage on saveresume.c now 2017-06-19 13:55:04 -04:00
Eric S. Raymond
ef100a3102 Publish more things on the website. 2017-06-19 13:21:15 -04:00
Eric S. Raymond
0eb85f233a Boolify some logical variables. 2017-06-19 13:21:15 -04:00
NHOrus
e9aff2568f Even less magic 2017-06-19 20:18:20 +03:00
Aaron Traas
18a9be501f Save/resume fail test coverage -- test works in Docker now 2017-06-19 13:09:15 -04:00
NHOrus
a8a7c50691 -r doesn't show with NOSAVE build 2017-06-19 19:29:00 +03:00
NHOrus
93a76e9d2f No need to tease with excluded options 2017-06-19 19:11:07 +03:00
Eric S. Raymond
f84c5033e9 Revert "Improved test coverage -- save/resume fail"
Fails in GitLab CI - looks like /dev/badfilename can actually be opened there.
2017-06-19 11:37:03 -04:00
Aaron Traas
e5b6f71d7a Improved test coverage -- save/resume fail 2017-06-19 11:24:46 -04:00
Eric S. Raymond
4c100261c4 Magic-number elimination. 2017-06-19 11:09:24 -04:00
Eric S. Raymond
d46407d327 Magic-number elimination. Fix possible glitch in troll-bridge death. 2017-06-19 11:00:23 -04:00
Eric S. Raymond
28f9fd59bb Add axeorama log, extending test coverage. 2017-06-19 10:32:58 -04:00
Eric S. Raymond
0b91efc9eb Restructure some code. 2017-06-19 09:46:04 -04:00
Eric S. Raymond
10e53a419e L12 is gone again. Magic numbers have been almost eliminated. 2017-06-19 08:43:51 -04:00
Eric S. Raymond
98b02eeeb1 Magic number elimination, repair some careless replace damage. 2017-06-19 08:37:19 -04:00
Eric S. Raymond
df86aa283b Documentation tweak. 2017-06-19 07:41:59 -04:00
Peje Nilsson
2fe36df4e2 Remove goto L12 - take two
On't know if you let me near this code again but here is a second
stab at removing "goto L12"

Previous attempt failed because of trying to continue the outer
do{}while(false)
Adding an extra for(;;) loop where the only repeat is the former
"goto L12" is replaced by continue. All other exits are returns
and a break;
2017-06-19 07:33:40 -04:00
Eric S. Raymond
c2df849dad Improve test coverage. 2017-06-19 07:33:40 -04:00
Jason S. Ninneman
0f3d3f735f Reorganize debug build options.
* 'make advent' by itself can be considered the 'release' build.
* 'make debug' now does 'make linty'.
2017-06-18 21:11:06 -07:00
Eric S. Raymond
d250b51030 Get usage message into coverage tests. 2017-06-18 23:31:59 -04:00
Jason S. Ninneman
06e8d5a83e Abolish MAXDIE in favor of maximum_deaths. 2017-06-18 20:02:03 -07:00
Jason S. Ninneman
803d2b6ef9 Clean old obit messages from adventure.yaml. 2017-06-18 19:59:43 -07:00
Jason S. Ninneman
fecc48e6e5 Remove message pointer math in croak(). 2017-06-18 19:54:48 -07:00
Jason S. Ninneman
624ba16aad Change YES() to take const char* arguments. 2017-06-18 19:51:59 -07:00
Jason S. Ninneman
9229fdf2a3 Give obituary messages their own data structure. 2017-06-18 19:44:35 -07:00
Eric S. Raymond
bba2af13d5 Typo fix. 2017-06-18 22:35:03 -04:00
Eric S. Raymond
7675b52562 More repairs on search-replace results. 2017-06-18 22:31:58 -04:00
Eric S. Raymond
962054cc26 Fix search-and-replace error. 2017-06-18 22:24:16 -04:00
Eric S. Raymond
fa9b6d317f No longer restricted to 6-character FORTRAN identifiers. 2017-06-18 21:17:57 -04:00
Eric S. Raymond
83ff9d0c0e Attempt to deconfuse the coverage analyzer. 2017-06-18 20:33:36 -04:00
Eric S. Raymond
fd02259c7f Reindent and cleanup. 2017-06-18 20:24:37 -04:00