Eric S. Raymond
f37a413524
Magic-number elimination.
2017-07-04 14:15:20 -04:00
Eric S. Raymond
a8ac2f477a
Abstract out some state arithmetic.
2017-07-04 13:41:12 -04:00
NHOrus
63396e6abc
Oops. Also, sometimes it's better be explicit in parameters
2017-07-04 19:50:19 +03:00
NHOrus
92de4856a6
Localized spk in discard
2017-07-04 19:45:00 +03:00
NHOrus
733b035933
Completed unspk'ing of vcarry.
2017-07-04 19:41:06 +03:00
NHOrus
e46cbdf194
Unspk'd (v)carry. Made logic more visible.
...
And tested some of newly exposed cases.
2017-07-04 19:30:22 +03:00
NHOrus
665103410a
Unspk'd and streamlined attack. Tested one of discovered gaps.
2017-07-04 18:41:28 +03:00
Aaron Traas
16a175bbab
Eliminated bivalve function.
...
Reason: only called in lock(), you can't be TOTING a clam, you can't
have the trident at a carryable oyster, and the code IMHO is more
readable this way.
2017-07-04 10:06:41 -04:00
Eric S. Raymond
e1cca3b28a
State-arithmetic elimination.
2017-07-04 09:17:20 -04:00
Eric S. Raymond
e31e69b172
Grammar fix.
2017-07-04 09:04:10 -04:00
NHOrus
85f918f9c0
Unspk'd chain action
2017-07-04 15:18:49 +03:00
NHOrus
469a0e74ed
linearized drink
2017-07-04 15:18:49 +03:00
NHOrus
3c636e27e2
linearized extinguish
2017-07-04 15:18:49 +03:00
NHOrus
8cbb8afcbe
Unspk'd and restructured fill
2017-07-04 15:18:49 +03:00
NHOrus
e6efd6dbac
Partial cleanup of fill
2017-07-04 15:18:49 +03:00
NHOrus
de5696431d
Unspk'd find
2017-07-04 15:18:49 +03:00
NHOrus
ffd08893dd
Unspk'd inventory lookup
2017-07-04 15:18:49 +03:00
NHOrus
b8def22d24
Unspk'd lock, cleaned up logic
2017-07-04 15:18:49 +03:00
NHOrus
babf08ddc4
Cleaned up unused variables
2017-07-04 15:18:49 +03:00
NHOrus
df2830598c
Unspk'd Giant Words
2017-07-04 15:18:49 +03:00
Eric S. Raymond
248fc90e3d
Another use of state_change().
2017-07-04 08:16:10 -04:00
Eric S. Raymond
e91b8c2a06
Another use of state_change() and changes messages.
2017-07-04 07:59:20 -04:00
Eric S. Raymond
393010ec41
Entirely eliminate wd1x and wd2x members of the command block.
...
In the process, fix another case-smashing bug.
2017-07-03 16:49:33 -04:00
Eric S. Raymond
a768555312
Use the raw buffer in tr command structure for editing.
...
This fixes some minor bugs. Unknown words are no longer truncated
nor uppercased on echo.
2017-07-03 12:52:28 -04:00
Eric S. Raymond
eba8015059
Magic-number elimination.
2017-07-03 07:14:15 -04:00
NHOrus
63152e6714
Broke all logical or into multiline statement to show lcov's lies
...
Results are weird, some things that need to be checked aren't and
at least my local lcov doesn't show them as unchecked
2017-07-03 07:20:37 +03:00
NHOrus
fc5267fe8b
Unspk'd bivalve action, exposing more untested surface
2017-07-03 06:46:24 +03:00
NHOrus
ac65f3fd5f
Unspk'd fly command
2017-07-03 06:29:02 +03:00
NHOrus
8b3ef7ca78
Unspk'd listen and lock commands
2017-07-03 06:21:38 +03:00
NHOrus
38970a1c98
Unspk'd pour command
2017-07-03 06:12:19 +03:00
NHOrus
5613b0ce36
Unspk and streamline eat command
2017-07-03 06:07:57 +03:00
NHOrus
e1f52f4e31
Removed helper function
2017-07-03 05:59:57 +03:00
Aaron Traas
9b3be62aaa
Remove testing for intransitive seperate from NO_OBJECT in attact()
...
because we look for it immediately below, and this code is never
reached. If it were, intransitive attacks would never work.
2017-07-02 21:56:49 -04:00
NHOrus
c7aecb7249
Removed spk from wave, fixed compiler warning
2017-07-03 01:01:01 +03:00
NHOrus
993194bd4d
Undid unspeaking of wave, fixed test again.
...
Changed property math to helper function.
2017-07-03 00:47:17 +03:00
NHOrus
eeda78a210
Don't spk in wave and action
2017-07-03 00:04:44 +03:00
NHOrus
8fcbc8ecba
More magic number elimination
2017-07-02 22:57:26 +03:00
NHOrus
fbc80f0363
Unfalsify coverage check
2017-07-02 22:57:25 +03:00
Eric S. Raymond
89e1833d8f
Magic-number elimination.
2017-07-02 15:32:50 -04:00
Eric S. Raymond
e712f4c0e0
Magic-number elimination.
2017-07-02 14:47:21 -04:00
Jason S. Ninneman
6af38a92f6
Eliminate the global game.blklin.
2017-07-02 10:37:10 -07:00
NHOrus
8456b866ff
Rationalize attack logic
...
Fix the compiler warnings about bunching ands with ors
2017-07-02 20:29:51 +03:00
Eric S. Raymond
346bcf9458
Magic-number elimination.
2017-07-02 13:22:50 -04:00
Aaron Traas
dd50e7c9d3
Eliminate unreachable code in lock()
2017-07-02 12:52:17 -04:00
NHOrus
29672a6447
Fixed logic, documented it in notes and tests
2017-07-02 17:50:42 +03:00
NHOrus
e91742e1b9
Fixed regression in #21 Cleaned up logic of light/extinguish
2017-07-02 10:16:13 -04:00
NHOrus
73af0e3a55
Fix for issue #21 , hopefully
2017-07-02 10:16:13 -04:00
NHOrus
a5478639b6
Capture wonkyness of extinguishing urn
2017-07-02 10:16:13 -04:00
Eric S. Raymond
4f08537e2d
More magic-number elimination.
2017-07-01 23:07:23 -04:00
Eric S. Raymond
5c2b76f762
Magic-number elimination.
2017-07-01 22:50:08 -04:00
