Aaron Traas
08c0524ee3
Test coverage -- intransitive carry when one object is present
2017-06-19 17:33:32 -04:00
Aaron Traas
7753ad3134
Test coverage - drink with no valid object
2017-06-19 17:33:32 -04:00
Eric S. Raymond
a678b68b39
Mostly confine assumptions about what token_t is to misc.c
...
The token_t things like WD* are presently longs and will someday be
char[6]. By introducing some trivial functions - wordeq(),
wordempty(), and wordclear() - we mostly hide the difference.
All runtime knowledge about packing now lives only in misc.c and the
list of magic WORD_* defines in advent.h. Outside this, literals are
now accessed through #define names that could expand to either longs
or strings.
Still to be done: WD* values are sometiimes compated to zero in
ways implying they can be negative. Must figure out wat thus means.
2017-06-19 17:21:45 -04:00
Eric S. Raymond
87961483a2
Concentrate all magic-number values for packed-string constants in one place.
2017-06-19 16:53:55 -04:00
Eric S. Raymond
79f5701e07
More semantic typing - a step towards eliminating packing.
2017-06-19 14:20:45 -04:00
Aaron Traas
f4ac82b9f8
Really 100% test coverage for saveresume.c
2017-06-19 13:55:04 -04:00
Aaron Traas
43247f995b
Should have 100% coverage on saveresume.c now
2017-06-19 13:55:04 -04:00
Eric S. Raymond
ef100a3102
Publish more things on the website.
2017-06-19 13:21:15 -04:00
Eric S. Raymond
0eb85f233a
Boolify some logical variables.
2017-06-19 13:21:15 -04:00
NHOrus
e9aff2568f
Even less magic
2017-06-19 20:18:20 +03:00
Aaron Traas
18a9be501f
Save/resume fail test coverage -- test works in Docker now
2017-06-19 13:09:15 -04:00
NHOrus
a8a7c50691
-r doesn't show with NOSAVE build
2017-06-19 19:29:00 +03:00
NHOrus
93a76e9d2f
No need to tease with excluded options
2017-06-19 19:11:07 +03:00
Eric S. Raymond
f84c5033e9
Revert "Improved test coverage -- save/resume fail"
...
Fails in GitLab CI - looks like /dev/badfilename can actually be opened there.
2017-06-19 11:37:03 -04:00
Aaron Traas
e5b6f71d7a
Improved test coverage -- save/resume fail
2017-06-19 11:24:46 -04:00
Eric S. Raymond
4c100261c4
Magic-number elimination.
2017-06-19 11:09:24 -04:00
Eric S. Raymond
d46407d327
Magic-number elimination. Fix possible glitch in troll-bridge death.
2017-06-19 11:00:23 -04:00
Eric S. Raymond
28f9fd59bb
Add axeorama log, extending test coverage.
2017-06-19 10:32:58 -04:00
Eric S. Raymond
0b91efc9eb
Restructure some code.
2017-06-19 09:46:04 -04:00
Eric S. Raymond
10e53a419e
L12 is gone again. Magic numbers have been almost eliminated.
2017-06-19 08:43:51 -04:00
Eric S. Raymond
98b02eeeb1
Magic number elimination, repair some careless replace damage.
2017-06-19 08:37:19 -04:00
Eric S. Raymond
df86aa283b
Documentation tweak.
2017-06-19 07:41:59 -04:00
Peje Nilsson
2fe36df4e2
Remove goto L12 - take two
...
On't know if you let me near this code again but here is a second
stab at removing "goto L12"
Previous attempt failed because of trying to continue the outer
do{}while(false)
Adding an extra for(;;) loop where the only repeat is the former
"goto L12" is replaced by continue. All other exits are returns
and a break;
2017-06-19 07:33:40 -04:00
Eric S. Raymond
c2df849dad
Improve test coverage.
2017-06-19 07:33:40 -04:00
Jason S. Ninneman
0f3d3f735f
Reorganize debug build options.
...
* 'make advent' by itself can be considered the 'release' build.
* 'make debug' now does 'make linty'.
2017-06-18 21:11:06 -07:00
Eric S. Raymond
d250b51030
Get usage message into coverage tests.
2017-06-18 23:31:59 -04:00
Jason S. Ninneman
06e8d5a83e
Abolish MAXDIE in favor of maximum_deaths.
2017-06-18 20:02:03 -07:00
Jason S. Ninneman
803d2b6ef9
Clean old obit messages from adventure.yaml.
2017-06-18 19:59:43 -07:00
Jason S. Ninneman
fecc48e6e5
Remove message pointer math in croak().
2017-06-18 19:54:48 -07:00
Jason S. Ninneman
624ba16aad
Change YES() to take const char* arguments.
2017-06-18 19:51:59 -07:00
Jason S. Ninneman
9229fdf2a3
Give obituary messages their own data structure.
2017-06-18 19:44:35 -07:00
Eric S. Raymond
bba2af13d5
Typo fix.
2017-06-18 22:35:03 -04:00
Eric S. Raymond
7675b52562
More repairs on search-replace results.
2017-06-18 22:31:58 -04:00
Eric S. Raymond
962054cc26
Fix search-and-replace error.
2017-06-18 22:24:16 -04:00
Eric S. Raymond
fa9b6d317f
No longer restricted to 6-character FORTRAN identifiers.
2017-06-18 21:17:57 -04:00
Eric S. Raymond
83ff9d0c0e
Attempt to deconfuse the coverage analyzer.
2017-06-18 20:33:36 -04:00
Eric S. Raymond
fd02259c7f
Reindent and cleanup.
2017-06-18 20:24:37 -04:00
Eric S. Raymond
5341a3e2ee
Add project logo. It'll have to do until we find an image of a miner's lamp.
2017-06-18 20:09:39 -04:00
Bob Little
04eca720d9
magic numbers, show usage, fixed linty warnings
...
Show usage when using bad parameter with ./advent
Converted magic numbers to enums for BUG(). Also bug now shows
stringify'ed version of bug enumeration (not just a number).
2017-06-18 19:33:21 -04:00
Jason S. Ninneman
65e2e472dd
Fix bug that made YES() case-sensitive.
...
Also fix a related memory leak.
2017-06-18 14:14:13 -07:00
Jason S. Ninneman
550734fd3f
Gut and rebuild YES() with cleaner approach that doesn't rely on packing.
...
The new support functions get_input() and echo_input() (and others not made yet) will eventually replace GETIN() and MAPLIN().
2017-06-18 13:39:59 -07:00
Eric S. Raymond
0dd961701f
This should get test coverage to 93%.
2017-06-18 16:39:01 -04:00
Eric S. Raymond
2622a9835a
Improve test coverage.
2017-06-18 16:27:12 -04:00
Eric S. Raymond
00514b0793
Improve test coverage.
2017-06-18 16:08:09 -04:00
Eric S. Raymond
83330fc0fd
Improve test coverage
2017-06-18 15:50:52 -04:00
Eric S. Raymond
67bf87eda0
Repair plover teleport and add a test for it.
2017-06-18 15:05:17 -04:00
Eric S. Raymond
2b89225ecd
Extent test coverage to plover room access.
2017-06-18 14:15:54 -04:00
Eric S. Raymond
409ffe4a86
Code simplification.
2017-06-18 14:02:24 -04:00
Eric S. Raymond
ba5c7dacb5
Remove unused code.
2017-06-18 13:20:04 -04:00
Jason S. Ninneman
672ef17d4c
Rename newspeak() to speak().
2017-06-18 10:06:14 -07:00
