Commit graph

256 commits

Author SHA1 Message Date
Eric S. Raymond
da6a090b83 Magic-number elimination. 2017-07-06 07:42:41 -04:00
NHOrus
fd3b08e7d1 Improve readability 2017-07-06 10:32:33 +03:00
NHOrus
53efcdf2d2 Cleaned up light and extinguish 2017-07-06 10:27:49 +03:00
NHOrus
a802db1ce0 Cleaned up eat 2017-07-06 10:18:18 +03:00
NHOrus
acf303a57f Pruned out special case of discarding the vase 2017-07-06 10:13:43 +03:00
NHOrus
7be2c233ed Cleared up lock/unlock logic 2017-07-06 10:12:55 +03:00
NHOrus
de2b1894f2 obj_t in actions. And some more magical word removal
Also, reindented everything, as usual
2017-07-06 10:05:11 +03:00
Eric S. Raymond
146abeae17 Magic-number elimination. 2017-07-05 21:45:55 -04:00
Eric S. Raymond
da1f251524 Remove arithmetic on a location number. 2017-07-05 20:51:45 -04:00
Eric S. Raymond
b2a686b07d Location arithmetic elimination. 2017-07-05 20:29:50 -04:00
Jason S. Ninneman
ad24add3c0 actions[] now has strings instead of enums. 2017-07-05 16:31:41 -07:00
Eric S. Raymond
c8cac18f42 Improve giant-words failure message. 2017-07-05 17:32:44 -04:00
Jason S. Ninneman
0e540429b0 Working but unpolished refactor of bigwords(). 2017-07-05 14:02:52 -07:00
NHOrus
b2d71155e9 same with bear, but without test 2017-07-05 15:41:36 -04:00
NHOrus
603f548a21 Fixed feed command and white space in tests 2017-07-05 15:41:36 -04:00
NHOrus
725105b4a2 Made feeding a switch instead of elsif chain 2017-07-05 15:41:36 -04:00
NHOrus
23aced5c7c One bit less math on states 2017-07-05 15:41:36 -04:00
NHOrus
40ff648431 Moved state_change to misc.c to start using it in main.c, too 2017-07-05 20:23:34 +03:00
NHOrus
c35cf99966 Static analysis warnings squished 2017-07-05 17:45:12 +03:00
Eric S. Raymond
7be7ac9406 Magic-number elimination. 2017-07-05 03:17:24 -04:00
Eric S. Raymond
c8f3289828 Minor clarifications. 2017-07-05 02:02:39 -04:00
Eric S. Raymond
31c1a44915 Adapt bottle object to use state_change(). 2017-07-05 01:15:40 -04:00
NHOrus
8613f0b3d9 Magic number elimination
Special state/locations for game.fixd object array
2017-07-05 07:56:36 +03:00
Eric S. Raymond
3d5c7239f1 Simplify vase-dropping logic using state_change(). 2017-07-05 00:40:14 -04:00
Eric S. Raymond
5ae09b9c34 Magic-number elimination. 2017-07-04 23:46:16 -04:00
Aaron Traas
19127d05df Removed equivocation between ROD and ROD2 in throw()
Already dealt with in action(), so redundant and unreachable here.
2017-07-04 17:13:26 -04:00
Eric S. Raymond
abf820bb5c Magic-number elimination. 2017-07-04 14:40:10 -04:00
Eric S. Raymond
f37a413524 Magic-number elimination. 2017-07-04 14:15:20 -04:00
Eric S. Raymond
a8ac2f477a Abstract out some state arithmetic. 2017-07-04 13:41:12 -04:00
NHOrus
63396e6abc Oops. Also, sometimes it's better be explicit in parameters 2017-07-04 19:50:19 +03:00
NHOrus
92de4856a6 Localized spk in discard 2017-07-04 19:45:00 +03:00
NHOrus
733b035933 Completed unspk'ing of vcarry. 2017-07-04 19:41:06 +03:00
NHOrus
e46cbdf194 Unspk'd (v)carry. Made logic more visible.
And tested some of newly exposed cases.
2017-07-04 19:30:22 +03:00
NHOrus
665103410a Unspk'd and streamlined attack. Tested one of discovered gaps. 2017-07-04 18:41:28 +03:00
Aaron Traas
16a175bbab Eliminated bivalve function.
Reason: only called in lock(), you can't be TOTING a clam, you can't
have the trident at a carryable oyster, and the code IMHO is more
readable this way.
2017-07-04 10:06:41 -04:00
Eric S. Raymond
e1cca3b28a State-arithmetic elimination. 2017-07-04 09:17:20 -04:00
Eric S. Raymond
e31e69b172 Grammar fix. 2017-07-04 09:04:10 -04:00
NHOrus
85f918f9c0 Unspk'd chain action 2017-07-04 15:18:49 +03:00
NHOrus
469a0e74ed linearized drink 2017-07-04 15:18:49 +03:00
NHOrus
3c636e27e2 linearized extinguish 2017-07-04 15:18:49 +03:00
NHOrus
8cbb8afcbe Unspk'd and restructured fill 2017-07-04 15:18:49 +03:00
NHOrus
e6efd6dbac Partial cleanup of fill 2017-07-04 15:18:49 +03:00
NHOrus
de5696431d Unspk'd find 2017-07-04 15:18:49 +03:00
NHOrus
ffd08893dd Unspk'd inventory lookup 2017-07-04 15:18:49 +03:00
NHOrus
b8def22d24 Unspk'd lock, cleaned up logic 2017-07-04 15:18:49 +03:00
NHOrus
babf08ddc4 Cleaned up unused variables 2017-07-04 15:18:49 +03:00
NHOrus
df2830598c Unspk'd Giant Words 2017-07-04 15:18:49 +03:00
Eric S. Raymond
248fc90e3d Another use of state_change(). 2017-07-04 08:16:10 -04:00
Eric S. Raymond
e91b8c2a06 Another use of state_change() and changes messages. 2017-07-04 07:59:20 -04:00
Eric S. Raymond
393010ec41 Entirely eliminate wd1x and wd2x members of the command block.
In the process, fix another case-smashing bug.
2017-07-03 16:49:33 -04:00