Eric S. Raymond
66fba512a7
Partially address GitLab issue #27 : arbitrary_messages unreachable
2017-07-14 11:33:22 -04:00
NHOrus
7f18e66866
Refactored discard to concentrate bird-related things in one place
2017-07-14 16:38:25 +03:00
NHOrus
66ba9a0101
Refactored carry for clarity
2017-07-14 16:38:25 +03:00
NHOrus
3d2ba18355
Do not base endgame bonus on arbitrary messages
...
This may break save files, but doesn't, due to padding
2017-07-14 16:38:25 +03:00
NHOrus
49d9ef1bee
No spk remains in the code base
2017-07-13 21:52:27 -04:00
Jason S. Ninneman
50efa22849
Express word type with an enum instead of magic numbers.
...
* Make a cleaner function for getting vocab metadata.
* Get rid of magic numbers.
* Purge get_vocab_id().
* Abolish the *_WORD() macros.
* Add FIXME comment on some ugliness.
2017-07-12 10:35:00 -07:00
Eric S. Raymond
00cf2a9373
Comment polishing.
2017-07-11 04:15:57 -04:00
Eric S. Raymond
96950869c6
Reindent.
2017-07-11 03:26:00 -04:00
Eric S. Raymond
d9aadeedba
LCOV exclusuon correction - addresses issue #25 .
2017-07-10 23:04:22 -04:00
Eric S. Raymond
76c6ab4cfa
Tweak a coverage exclusion.
2017-07-10 14:57:55 -04:00
Eric S. Raymond
9a16382b12
Bear can't dies where it can be chained.
2017-07-10 12:49:45 -04:00
NHOrus
53cb12b4d0
Bound the sizes of strcpy.
2017-07-08 15:16:21 -04:00
NHOrus
51b6b52dc8
Eliminated multiple reassigments
2017-07-07 10:20:32 +03:00
NHOrus
ea4986e0f5
Stop overwriting obj by dragon check
2017-07-06 19:12:16 +03:00
NHOrus
8f5c262e6d
Semantic type for verb
2017-07-06 18:40:11 +03:00
NHOrus
cca3686f2f
Clear login in bvreak
...
Test double-breaking of vase
2017-07-06 18:23:07 +03:00
NHOrus
0a04293f23
Prevent multiple assigment to game.bonus in blast
2017-07-06 18:18:31 +03:00
NHOrus
adab8e2190
Be explicitely intransitive
2017-07-06 18:11:02 +03:00
NHOrus
ca7ac4063f
Magic-number elimination and fix
...
More test coverage for some of the cases
2017-07-06 17:55:56 +03:00
Eric S. Raymond
da6a090b83
Magic-number elimination.
2017-07-06 07:42:41 -04:00
NHOrus
fd3b08e7d1
Improve readability
2017-07-06 10:32:33 +03:00
NHOrus
53efcdf2d2
Cleaned up light and extinguish
2017-07-06 10:27:49 +03:00
NHOrus
a802db1ce0
Cleaned up eat
2017-07-06 10:18:18 +03:00
NHOrus
acf303a57f
Pruned out special case of discarding the vase
2017-07-06 10:13:43 +03:00
NHOrus
7be2c233ed
Cleared up lock/unlock logic
2017-07-06 10:12:55 +03:00
NHOrus
de2b1894f2
obj_t in actions. And some more magical word removal
...
Also, reindented everything, as usual
2017-07-06 10:05:11 +03:00
Eric S. Raymond
146abeae17
Magic-number elimination.
2017-07-05 21:45:55 -04:00
Eric S. Raymond
da1f251524
Remove arithmetic on a location number.
2017-07-05 20:51:45 -04:00
Eric S. Raymond
b2a686b07d
Location arithmetic elimination.
2017-07-05 20:29:50 -04:00
Jason S. Ninneman
ad24add3c0
actions[] now has strings instead of enums.
2017-07-05 16:31:41 -07:00
Eric S. Raymond
c8cac18f42
Improve giant-words failure message.
2017-07-05 17:32:44 -04:00
Jason S. Ninneman
0e540429b0
Working but unpolished refactor of bigwords().
2017-07-05 14:02:52 -07:00
NHOrus
b2d71155e9
same with bear, but without test
2017-07-05 15:41:36 -04:00
NHOrus
603f548a21
Fixed feed command and white space in tests
2017-07-05 15:41:36 -04:00
NHOrus
725105b4a2
Made feeding a switch instead of elsif chain
2017-07-05 15:41:36 -04:00
NHOrus
23aced5c7c
One bit less math on states
2017-07-05 15:41:36 -04:00
NHOrus
40ff648431
Moved state_change to misc.c to start using it in main.c, too
2017-07-05 20:23:34 +03:00
NHOrus
c35cf99966
Static analysis warnings squished
2017-07-05 17:45:12 +03:00
Eric S. Raymond
7be7ac9406
Magic-number elimination.
2017-07-05 03:17:24 -04:00
Eric S. Raymond
c8f3289828
Minor clarifications.
2017-07-05 02:02:39 -04:00
Eric S. Raymond
31c1a44915
Adapt bottle object to use state_change().
2017-07-05 01:15:40 -04:00
NHOrus
8613f0b3d9
Magic number elimination
...
Special state/locations for game.fixd object array
2017-07-05 07:56:36 +03:00
Eric S. Raymond
3d5c7239f1
Simplify vase-dropping logic using state_change().
2017-07-05 00:40:14 -04:00
Eric S. Raymond
5ae09b9c34
Magic-number elimination.
2017-07-04 23:46:16 -04:00
Aaron Traas
19127d05df
Removed equivocation between ROD and ROD2 in throw()
...
Already dealt with in action(), so redundant and unreachable here.
2017-07-04 17:13:26 -04:00
Eric S. Raymond
abf820bb5c
Magic-number elimination.
2017-07-04 14:40:10 -04:00
Eric S. Raymond
f37a413524
Magic-number elimination.
2017-07-04 14:15:20 -04:00
Eric S. Raymond
a8ac2f477a
Abstract out some state arithmetic.
2017-07-04 13:41:12 -04:00
NHOrus
63396e6abc
Oops. Also, sometimes it's better be explicit in parameters
2017-07-04 19:50:19 +03:00
NHOrus
92de4856a6
Localized spk in discard
2017-07-04 19:45:00 +03:00
