Commit graph

269 commits

Author SHA1 Message Date
Eric S. Raymond
94e7cc6505 Address Gitlab isse #62: Comment typos. 2023-03-01 13:04:53 -05:00
Eric S. Raymond
d320212622 Indent cleanup. 2022-04-18 10:31:13 -04:00
Eric S. Raymond
4069bf210b cppcheck cleanup. 2022-04-13 20:55:57 -04:00
Eric S. Raymond
49e2479efa Improve test coverage. 2022-04-07 06:42:20 -04:00
Eric S. Raymond
dd5ca23302 Second part of fix for "fee fie foe foo" and "fum", with test. 2022-04-06 14:41:30 -04:00
Eric S. Raymond
db384731a7 Address GitLab issue #56: handling of "fee fie foe foo" and "fum"
Also add a regression test for this.
2022-04-06 13:43:08 -04:00
Eric S. Raymond
46e1595cb0 Address Gitlanb issue #54: listen command not showing all sounds 2022-04-06 07:49:42 -04:00
Eric S. Raymond
73b49d27f4 Fix issue #51: rug flying is broken
And add a test for the fix.
2022-04-05 15:18:17 -04:00
Eric S. Raymond
f2f238e9e4 Address GitLab issue #55: water should not be available in endgame. 2021-02-15 22:21:26 -05:00
Eric S. Raymond
747c42029d Attempt fix for issue #52: endgame oyster reading is incorrect 2021-01-11 00:14:51 -05:00
Eric S. Raymond
8984e48e78 Attempting fix for issue #50: carried clam can be opened (with trident) 2021-01-10 22:14:11 -05:00
Aaron Traas
e7dc3eab5d Correct return types for all of the action handling functions in actions, so it's clear we're not just using arbitrary ints 2018-12-07 10:36:42 -05:00
Eric S. Raymond
6667ffd1f1 Address GitLab issue #45: OSX Compile issue 2018-11-30 09:50:25 -05:00
Eric S. Raymond
a4c87aa0b3 Fix for GitLab issue #37: prompt incorrectly handled. 2018-11-14 13:01:39 -05:00
Eric S. Raymond
782c5c3f29 SPDXify the code. 2018-03-08 20:56:21 -05:00
NHOrus
4e4c2e0198 Be consistent 2017-09-11 00:58:13 +03:00
NHOrus
9e2cb3c191 Put some of important parameters into fixed width signed integers
Massaged test files. Fixes issue #41
2017-09-11 00:58:13 +03:00
NHOrus
0fbd79b608 Reindentation 2017-08-13 15:56:07 +01:00
Eric S. Raymond
cf92b9d9d6 Remove duplicative phase code. 2017-08-03 15:51:39 -04:00
Eric S. Raymond
87c6d3fb1e Canonicalize OV commands to VO form.
Allows us to get rid of some obscure logic that causes an unnecessary
word shift. One error message changes in a benign way.
2017-08-03 15:02:41 -04:00
Jason S. Ninneman
24d102781c Typedefify command_t; simplify code accordingly. 2017-08-03 08:29:46 -07:00
Jason S. Ninneman
5c91ea3739 Encapsulate command words into their own struct. 2017-08-03 08:24:18 -07:00
Eric S. Raymond
e50f1b8a7b Coverage repair. 2017-07-31 15:26:56 -04:00
Aaron Traas
ca5374edc3 Modified action() to take take a copy of command rather than a pointer.
It should be safer now that we're not scribbling all over command in
action(), as it's closer to pure. Also fixed a bug in say.
2017-07-21 18:27:02 -04:00
Aaron Traas
5f28f95244 All specials are now actions. Builds correct outputs, more needs deleting. 2017-07-21 16:56:43 -04:00
Eric S. Raymond
80b2b9b356 Simplify seed and waste cpmands using %d in the YAML string. 2017-07-21 14:03:39 -04:00
Aaron Traas
5337e00725 Fix to Gitlab issue #32. Now SEED and WASTE are in adventure.yaml
NOTE: the tests are all updated because now, like every other action,
SEED and WASTE have a \n before their output, as they correctly use
SPEAK
2017-07-21 10:23:02 -04:00
Eric S. Raymond
a3c159660b Comment cleanup, semantic types, information hiding. 2017-07-21 07:38:09 -04:00
Eric S. Raymond
609159ad6d Abolish as many undifferentiated long variables as possible.
Simple counter become ints.
2017-07-20 18:49:08 -04:00
Eric S. Raymond
342994376a Address GitLab issue #28: Advent hangs on some inputs 2017-07-20 12:24:02 -04:00
Eric S. Raymond
08f260c4d5 Fix Gitlab issue #30: Say is broken. 2017-07-20 10:47:33 -04:00
Eric S. Raymond
8bd947b54d Last remnants of packing removed.
As a bonus, a bug in %S pluralization became obvious and was fixed.
2017-07-20 10:36:22 -04:00
Eric S. Raymond
08c40bc999 Eliminate last logic guard on a packed value. 2017-07-20 09:50:58 -04:00
Eric S. Raymond
29b8f5b142 Remove a packing call - word buffer is good enough. 2017-07-20 09:11:13 -04:00
Eric S. Raymond
4e01669e06 Remove special-case code that was inducing bugs. 2017-07-20 09:08:10 -04:00
Eric S. Raymond
52723acb72 Eliminate some uses of wd2 - tests can be done on raw2 buffer instead. 2017-07-20 07:09:20 -04:00
Jason S. Ninneman
8ac4a59a67 Tell the compiler not to warn about legitimate case fallthroughs. 2017-07-19 09:47:20 -07:00
Eric S. Raymond
9b5142af5a De-FORTRANIZE some IDs. 2017-07-16 16:05:26 -04:00
NHOrus
614d9b34ad Removed temporary variable for clarity; Upsized text buffer in fallback to maximum possible size 2017-07-16 16:07:23 +03:00
NHOrus
8d9c8e4d5c Deal with more agressive gcov 7.1; Reindent 2017-07-16 16:00:19 +03:00
Eric S. Raymond
9eda1f424d Apply state_change() to mirror object. 2017-07-16 05:08:03 -04:00
Eric S. Raymond
d1e29319fa Code cleanup. 2017-07-14 13:10:13 -04:00
Jason S. Ninneman
e581c7741d Replace some more wd? with id?. 2017-07-14 09:18:55 -07:00
Jason S. Ninneman
596a15457d Dragon attack code no longer edits the command struct.
This also fixes a minor bug where refusing to attack the dragon
costs the player two turns instead of one.
2017-07-14 09:18:55 -07:00
Eric S. Raymond
66fba512a7 Partially address GitLab issue #27: arbitrary_messages unreachable 2017-07-14 11:33:22 -04:00
NHOrus
7f18e66866 Refactored discard to concentrate bird-related things in one place 2017-07-14 16:38:25 +03:00
NHOrus
66ba9a0101 Refactored carry for clarity 2017-07-14 16:38:25 +03:00
NHOrus
3d2ba18355 Do not base endgame bonus on arbitrary messages
This may break save files, but doesn't, due to padding
2017-07-14 16:38:25 +03:00
NHOrus
49d9ef1bee No spk remains in the code base 2017-07-13 21:52:27 -04:00
Jason S. Ninneman
50efa22849 Express word type with an enum instead of magic numbers.
* Make a cleaner function for getting vocab metadata.
* Get rid of magic numbers.
* Purge get_vocab_id().
* Abolish the *_WORD() macros.
* Add FIXME comment on some ugliness.
2017-07-12 10:35:00 -07:00