Jason S. Ninneman
d029b08ad1
Refactor how turn threshold penalties are accounted for.
2017-06-20 19:26:55 -04:00
Eric S. Raymond
7a3f3ec7a6
Introduce command encapsulation structure.
2017-06-20 17:40:41 -04:00
Eric S. Raymond
e37f858b08
Comment polishing.
2017-06-20 13:38:11 -04:00
Eric S. Raymond
521033165b
Polish help text.
2017-06-20 08:41:06 -04:00
Peje Nilsson
c84d370918
Merge branch 'master' into magic-number
2017-06-19 23:44:48 +02:00
Peje Nilsson
f9be57a9f9
Cleanup Arithmetic on message number
2017-06-19 23:44:03 +02:00
Eric S. Raymond
a678b68b39
Mostly confine assumptions about what token_t is to misc.c
...
The token_t things like WD* are presently longs and will someday be
char[6]. By introducing some trivial functions - wordeq(),
wordempty(), and wordclear() - we mostly hide the difference.
All runtime knowledge about packing now lives only in misc.c and the
list of magic WORD_* defines in advent.h. Outside this, literals are
now accessed through #define names that could expand to either longs
or strings.
Still to be done: WD* values are sometiimes compated to zero in
ways implying they can be negative. Must figure out wat thus means.
2017-06-19 17:21:45 -04:00
Eric S. Raymond
87961483a2
Concentrate all magic-number values for packed-string constants in one place.
2017-06-19 16:53:55 -04:00
Eric S. Raymond
79f5701e07
More semantic typing - a step towards eliminating packing.
2017-06-19 14:20:45 -04:00
Eric S. Raymond
0eb85f233a
Boolify some logical variables.
2017-06-19 13:21:15 -04:00
NHOrus
e9aff2568f
Even less magic
2017-06-19 20:18:20 +03:00
NHOrus
a8a7c50691
-r doesn't show with NOSAVE build
2017-06-19 19:29:00 +03:00
NHOrus
93a76e9d2f
No need to tease with excluded options
2017-06-19 19:11:07 +03:00
Eric S. Raymond
4c100261c4
Magic-number elimination.
2017-06-19 11:09:24 -04:00
Eric S. Raymond
d46407d327
Magic-number elimination. Fix possible glitch in troll-bridge death.
2017-06-19 11:00:23 -04:00
Eric S. Raymond
98b02eeeb1
Magic number elimination, repair some careless replace damage.
2017-06-19 08:37:19 -04:00
Peje Nilsson
2fe36df4e2
Remove goto L12 - take two
...
On't know if you let me near this code again but here is a second
stab at removing "goto L12"
Previous attempt failed because of trying to continue the outer
do{}while(false)
Adding an extra for(;;) loop where the only repeat is the former
"goto L12" is replaced by continue. All other exits are returns
and a break;
2017-06-19 07:33:40 -04:00
Jason S. Ninneman
06e8d5a83e
Abolish MAXDIE in favor of maximum_deaths.
2017-06-18 20:02:03 -07:00
Jason S. Ninneman
fecc48e6e5
Remove message pointer math in croak().
2017-06-18 19:54:48 -07:00
Jason S. Ninneman
624ba16aad
Change YES() to take const char* arguments.
2017-06-18 19:51:59 -07:00
Eric S. Raymond
7675b52562
More repairs on search-replace results.
2017-06-18 22:31:58 -04:00
Eric S. Raymond
fa9b6d317f
No longer restricted to 6-character FORTRAN identifiers.
2017-06-18 21:17:57 -04:00
Eric S. Raymond
fd02259c7f
Reindent and cleanup.
2017-06-18 20:24:37 -04:00
Bob Little
04eca720d9
magic numbers, show usage, fixed linty warnings
...
Show usage when using bad parameter with ./advent
Converted magic numbers to enums for BUG(). Also bug now shows
stringify'ed version of bug enumeration (not just a number).
2017-06-18 19:33:21 -04:00
Jason S. Ninneman
550734fd3f
Gut and rebuild YES() with cleaner approach that doesn't rely on packing.
...
The new support functions get_input() and echo_input() (and others not made yet) will eventually replace GETIN() and MAPLIN().
2017-06-18 13:39:59 -07:00
Eric S. Raymond
67bf87eda0
Repair plover teleport and add a test for it.
2017-06-18 15:05:17 -04:00
Eric S. Raymond
409ffe4a86
Code simplification.
2017-06-18 14:02:24 -04:00
Jason S. Ninneman
672ef17d4c
Rename newspeak() to speak().
2017-06-18 10:06:14 -07:00
Eric S. Raymond
704b86afbb
Refactor scoring so score() does not conditionally exit.
2017-06-18 12:51:05 -04:00
Eric S. Raymond
937714f31d
Magic-number limination. Improve test coverage.
2017-06-18 09:44:34 -04:00
Eric S. Raymond
b3057f038b
Re-format to consistent indent style with "make indent".
2017-06-18 06:18:51 -04:00
Bob Little
d844c2a391
Added 'linty' target for make
...
"make linty" does lots of error checking while compiling.
Simplified the standard make's CFLAGS.
Cleaned up code to eliminate resulting warnings generated by "make linty".
2017-06-17 22:28:40 -04:00
Bob Little
a3485d2a41
Move a few prototypes and static'ed a few functions
...
Moved prototypes for initialise() and action() from main.c to advent.h
Made the following functions static, so they wouldn't require prototypes:
sig_handler (main.c)
spotted_by_pirate (main.c)
light (actions.c)
2017-06-17 18:19:09 -04:00
NHOrus
a0a35d8c7b
Improved docs, fixed identation
2017-06-17 11:09:55 -04:00
NHOrus
32fdd08d9b
Little cleanup of variable names
2017-06-17 17:48:12 +03:00
NHOrus
300d246179
Resume from file on startup
2017-06-17 09:20:42 +03:00
Eric S. Raymond
1596e6d81e
Code simplification.
2017-06-16 15:58:51 -04:00
Eric S. Raymond
59a558b762
Code simplification.
2017-06-16 15:08:21 -04:00
Eric S. Raymond
d97574d35c
Magic-number elimination.
2017-06-16 08:55:53 -04:00
Eric S. Raymond
a57d93ce35
Magic-number elimination.
2017-06-16 07:00:57 -04:00
Eric S. Raymond
ec031b0417
Name another magic number.
2017-06-15 17:34:06 -04:00
Eric S. Raymond
fc7f52f83f
Don't do dwarf moves after a fallback command.
...
Avoids a crash bug.
2017-06-15 16:54:29 -04:00
Eric S. Raymond
14486d67d4
Magic-numnber elimination.
2017-06-15 12:19:06 -04:00
Eric S. Raymond
49edca485d
More use of manifeat constants.
2017-06-15 11:15:45 -04:00
Eric S. Raymond
0dc78b4221
More use of manifest constants.
2017-06-15 10:59:43 -04:00
Eric S. Raymond
1896e0f886
Use symbolic shortnames for locations.
2017-06-15 10:31:26 -04:00
NHOrus
f1f7cfd4e9
Localizing variables
2017-06-15 16:16:21 +03:00
Eric S. Raymond
e5f9c4fbea
Use LOC_* constants for locations. Clean up some ARB_* constants.
2017-06-15 08:49:47 -04:00
Eric S. Raymond
a141f021d5
Meaningful shortnames for RSPEAK messages.
2017-06-15 07:35:03 -04:00
Eric S. Raymond
1d37262a16
More ARB tagging.
2017-06-15 07:16:39 -04:00